From: Dan Carpenter <dan.carpenter@oracle.com>
To: Adil Mujeeb <mujeeb.adil@gmail.com>
Cc: pavel@ucw.cz, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Staging: winbond: wb35rx_s: Fixed coding style issue
Date: Thu, 8 Nov 2012 10:29:15 +0300 [thread overview]
Message-ID: <20121108072915.GD11515@mwanda> (raw)
In-Reply-To: <1352314203-8092-5-git-send-email-mujeeb.adil@gmail.com>
It's better to use more descriptive subjects on the patches.
This one could probably have been broken into smaller patches
[patch 4/x] Staging: winbond: wb35rx_s: fix white space
[patch 5/x] Staging: winbond: wb35rx_s: fix comments
[patch 6/x] Staging: winbond: wb35rx_s: allow header to be included twice
It's small enough that I don't have strong feelings about it, but
in general that's how you should do it.
regards,
dan carpenter
next prev parent reply other threads:[~2012-11-08 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 18:49 [PATCH 0/4] Staging: winbond: wbusb: Fixed coding style issue Adil Mujeeb
2012-11-07 18:50 ` [PATCH 1/4] " Adil Mujeeb
2012-11-07 18:50 ` [PATCH 2/4] Staging: winbond: mds: Fixed coding style issues Adil Mujeeb
2012-11-07 18:50 ` [PATCH 3/4] Staging: winbond: wb35rx_f: " Adil Mujeeb
2012-11-07 18:50 ` [PATCH 4/4] Staging: winbond: wb35rx_s: Fixed coding style issue Adil Mujeeb
2012-11-08 7:29 ` Dan Carpenter [this message]
2012-11-08 9:57 ` Adil Mujeeb
2012-11-09 18:01 ` [PATCH 0/4] Staging: winbond: wbusb: " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108072915.GD11515@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mujeeb.adil@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.