From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171Ab2KHMkf (ORCPT ); Thu, 8 Nov 2012 07:40:35 -0500 Received: from mga02.intel.com ([134.134.136.20]:43362 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118Ab2KHMkd (ORCPT ); Thu, 8 Nov 2012 07:40:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,737,1344236400"; d="scan'208";a="216774144" Date: Thu, 8 Nov 2012 20:40:24 +0800 From: Fengguang Wu To: Julia Lawall Cc: Yuanhan Liu , changlongx.xie@intel.com, Steve Glendinning , "netdev@vger.kernel.org" , linux-usb@vger.kernel.org, LKML Subject: Re: [net-next:master 209/235] drivers/net/usb/smsc95xx.c:1134:39-50: ERROR: reference preceded by free on line 1136 Message-ID: <20121108124024.GA9627@localhost> References: <509b644e.GcrhQalfrxVfFLjF%yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Julia, On Thu, Nov 08, 2012 at 09:08:04AM +0100, Julia Lawall wrote: > It's a false positive because check_warn_return does a return. Right. > But I wonder if there is a way that we can encourage people not to > do things like that? Well I suspect the memory leak bug 06a221be0 tries to fix might be due to check_warn_return() hiding the otherwise very obvious syntax highlighted 'return' statement. Thanks, Fengguang > >TO: Ming Lei > >CC: netdev@vger.kernel.org > > > > > >Hi Ming, > > > >FYI, there are coccinelle warnings in > > > >tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master > >head: f1e0b5b4f1eae56a3192688177f36e2bdf0e01ac > >commit: 06a221be022c2cc98a48e0808a4ef0dc8f0b3a34 [209/235] usbnet: smsc95xx: fix memory leak in smsc95xx_suspend > >:::::: branch date: 8 hours ago > >:::::: commit date: 23 hours ago > > > >+ drivers/net/usb/smsc95xx.c:1134:39-50: ERROR: reference preceded by free on line 1136 > > drivers/net/usb/smsc95xx.c:1139:8-19: ERROR: reference preceded by free on line 1136 > > > >git remote update net-next > >git checkout 06a221be022c2cc98a48e0808a4ef0dc8f0b3a34 > >vim +1134 drivers/net/usb/smsc95xx.c > > > >bbd9f9ee Steve Glendinning 2012-10-26 1128 offset[filter/4] |= 0x00 << ((filter % 4) * 8); > >bbd9f9ee Steve Glendinning 2012-10-26 1129 crc[filter/2] |= smsc_crc(dev->net->dev_addr, ETH_ALEN, filter); > >bbd9f9ee Steve Glendinning 2012-10-26 1130 filter++; > >bbd9f9ee Steve Glendinning 2012-10-26 1131 } > >bbd9f9ee Steve Glendinning 2012-10-26 1132 > >bbd9f9ee Steve Glendinning 2012-10-26 1133 for (i = 0; i < (pdata->wuff_filter_count * 4); i++) { > >bbd9f9ee Steve Glendinning 2012-10-26 @1134 ret = smsc95xx_write_reg(dev, WUFF, filter_mask[i]); > >06a221be Ming Lei 2012-11-06 1135 if (ret < 0) > >06a221be Ming Lei 2012-11-06 @1136 kfree(filter_mask); > >bbd9f9ee Steve Glendinning 2012-10-26 1137 check_warn_return(ret, "Error writing WUFF"); > >bbd9f9ee Steve Glendinning 2012-10-26 1138 } > >06a221be Ming Lei 2012-11-06 1139 kfree(filter_mask); > > > >:::::: The code at line 1134 was first introduced by commit: > >:::::: bbd9f9e smsc95xx: add wol support for more frame types > > > >:::::: TO: Steve Glendinning > >:::::: CC: David S. Miller > > > >--- > >0-DAY kernel build testing backend Open Source Technology Center > >Fengguang Wu, Yuanhan Liu Intel Corporation > >