From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: VIC: remove unused irq_base variable
Date: Thu, 8 Nov 2012 13:40:54 +0000 [thread overview]
Message-ID: <201211081340.54440.arnd@arndb.de> (raw)
In-Reply-To: <1350392786-29191-1-git-send-email-linus.walleij@stericsson.com>
"ARM: VIC: use irq_domain_add_simple()" causes a new warning:
arch/arm/common/vic.c: In function 'vic_of_init':
arch/arm/common/vic.c:410:6: warning: unused variable 'irq_base' [-Wunused-variable]
Since the irq_base variable is not used any more, it should be
removed now
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
On Tuesday 16 October 2012, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> Instead of allocating descriptors on-the-fly for the device tree
> initialization case, use irq_domain_add_simple() which will take
> care of this if you pass negative as the first_irq.
>
> Alter the signature of __vic_init() to pass the first_irq as
> signed so this works as expected.
>
> Switching the VIC to use irq_domain_add_simple() also has the
> upside of displaying the same WARNING when you boot with
> pre-allocated descriptors on systems using SPARSE_IRQ but
> yet not using device tree.
>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
diff --git a/arch/arm/common/vic.c b/arch/arm/common/vic.c
index 4fd5d98..e4df17c 100644
--- a/arch/arm/common/vic.c
+++ b/arch/arm/common/vic.c
@@ -407,7 +407,6 @@ void __init vic_init(void __iomem *base, unsigned int irq_start,
int __init vic_of_init(struct device_node *node, struct device_node *parent)
{
void __iomem *regs;
- int irq_base;
if (WARN(parent, "non-root VICs are not supported"))
return -EINVAL;
next prev parent reply other threads:[~2012-11-08 13:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 13:06 [PATCH] ARM: VIC: use irq_domain_add_simple() Linus Walleij
2012-10-16 13:32 ` Rob Herring
2012-12-18 23:34 ` Grant Likely
2012-12-20 18:45 ` Linus Walleij
2012-12-26 0:43 ` Linus Walleij
2013-01-11 18:57 ` Grant Likely
2013-01-11 20:38 ` Linus Walleij
2012-11-08 13:40 ` Arnd Bergmann [this message]
2012-11-08 13:55 ` [PATCH] ARM: VIC: remove unused irq_base variable Russell King - ARM Linux
2012-11-08 14:00 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211081340.54440.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.