From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 8 Nov 2012 14:08:34 +0100
Subject: [U-Boot] [PATCH v4] video: atmel: implement lcd_setcolreg
	funtion
In-Reply-To: <1352365815-24421-1-git-send-email-voice.shen@atmel.com>
References: <1352196829-27879-2-git-send-email-andreas.devel@googlemail.com>
	<1352365815-24421-1-git-send-email-voice.shen@atmel.com>
Message-ID: <201211081408.34347.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Bo Shen,

[...]
> +/*
> + * the CLUT register map as following
> + * RCLUT(24 ~ 16), GCLUT(15 ~ 8), BCLUT(7 ~ 0)
> + */
> +void lcd_setcolreg(ushort regno, ushort red, ushort green, ushort blue)
> +{
> +	lcdc_writel((red << 16) & 0xff0000 | (green << 8) & 0xff00 |
> +		blue & 0xff, panel_info.mmio + ATMEL_LCDC_LUT(regno));
> +}
> +

Why don't you #define these values instead?

>  void lcd_ctrl_init(void *lcdbase)
>  {
>  	unsigned long value;

Best regards,
Marek Vasut