From: Ben Myers <bpm@sgi.com>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Update inode alloc comments
Date: Thu, 8 Nov 2012 11:45:08 -0600 [thread overview]
Message-ID: <20121108174508.GO9783@sgi.com> (raw)
In-Reply-To: <20121102221244.GI9783@sgi.com>
On Fri, Nov 02, 2012 at 05:12:44PM -0500, Ben Myers wrote:
> Hey Carlos,
>
> On Sat, Oct 20, 2012 at 11:08:19AM -0300, Carlos Maiolino wrote:
> > I found some out of date comments while studying the inode allocation code, so I
> > believe it's worth to have these comments updated.
> >
> > It basically rewrites the comment regarding to "call_again" variable, which is
> > not used anymore, but instead, callers of xfs_ialloc() decides if it needs to be
> > called again relying only if ialloc_context is NULL or not.
> >
> > Also did some small changes in another comment that I thought to be pertinent
> > to the current behaviour of these functions and some alignment on both comments.
> >
> > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> > ---
> > fs/xfs/xfs_ialloc.c | 6 +++---
> > fs/xfs/xfs_inode.c | 18 +++++++++---------
> > 2 files changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c
> > index 445bf1a..f1a6046 100644
> > --- a/fs/xfs/xfs_ialloc.c
> > +++ b/fs/xfs/xfs_ialloc.c
> > @@ -876,9 +876,9 @@ error0:
> > * This function is designed to be called twice if it has to do an allocation
> > * to make more free inodes. On the first call, *IO_agbp should be set to NULL.
> > * If an inode is available without having to performn an allocation, an inode
> > - * number is returned. In this case, *IO_agbp would be NULL. If an allocation
> > - * needes to be done, xfs_dialloc would return the current AGI buffer in
> > - * *IO_agbp. The caller should then commit the current transaction, allocate a
> > + * number is returned. In this case, *IO_agbp is set to NULL. If an allocation
> > + * needes to be done, xfs_dialloc returns the current AGI buffer in *IO_agbp.
> needs
>
> Since we're at it.
>
> Looks fine.
>
> Reviewed-by: Ben Myers <bpm@sgi.com>
Carlos,
Committed this to git://oss.sgi.com/xfs/xfs.git, master & for-next on Nov 2.
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-11-08 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 14:08 [PATCH] xfs: Update inode alloc comments Carlos Maiolino
2012-10-23 12:23 ` Christoph Hellwig
2012-11-02 22:12 ` Ben Myers
2012-11-08 17:45 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108174508.GO9783@sgi.com \
--to=bpm@sgi.com \
--cc=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.