All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linas Vepstas <linasvepstas@gmail.com>
To: linux-pci@vger.kernel.org
Cc: "Pandarathil, Vijaymohan R" <vijaymohan.pandarathil@hp.com>
Subject: PCI error recovery patch [was: Request for feedback]
Date: Thu, 8 Nov 2012 13:14:09 -0600	[thread overview]
Message-ID: <20121108191409.GA23458@linas.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]



Hi Vijay,

I no longer actively maintain the error recovery stack.  However, your patch
and explanation for it looks reasonable to me --- it was certainly never the
intent that a non-capable driver report a successful recovery. 

I'm guessing that the bug that you are fixing was introduced when the
original pci error recovery code was integrated with AER (PCI-AER was
standardized after the original error recovery system was created, and I did
not really pay very much attention to AER at the time).

FWIW, I guess I could add a 

Signed-off-by: Linas Vepstas <linasvepstas@gmail.com>

but I'm not sure that really means much any more :-)

-- Linas


On 7 November 2012 21:50, Pandarathil, Vijaymohan R <vijaymohan.pandarathil@hp.com> wrote:
> Hi Bjorn/Linas,
> 
> I got your names from the PCI/PCI-error-recovery maintainers list. I had
> posted the following request last week.
> http://article.gmane.org/gmane.linux.kernel.pci/18465
> 
> Being a newbie, it would be extremely helpful to get your guidance on
> these changes, specifically on any side effects it has. I am also working
> on another set of patches to improve the PCI error recovery/containment
> capabilities of KVM. But if the above change cannot be made first, I may
> have to figure out alternate approach for the second set of patches.
> 
> Thanks
> 
> Vijay

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2012-11-08 19:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08 19:14 Linas Vepstas [this message]
     [not found] <CAHrUA35gL7=PjjqsgH3T=MRnM7LuzKAT1g8+DkZLMfGvJOy3KQ@mail.gmail.com>
2012-11-08 19:12 ` PCI error recovery patch [was: Request for feedback] Linas Vepstas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121108191409.GA23458@linas.org \
    --to=linasvepstas@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=vijaymohan.pandarathil@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.