All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Harvey <charvey@matrox.com>
To: Ivan Djelic <ivan.djelic@parrot.com>
Cc: "stefan.bigler@keymile.com" <stefan.bigler@keymile.com>,
	"Brunck, Holger" <Holger.Brunck@keymile.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Gerlando Falauto <gerlando.falauto@keymile.com>
Subject: Re: state of support for "external ECC hardware"
Date: Thu, 8 Nov 2012 14:22:50 -0500	[thread overview]
Message-ID: <20121108192250.GU2389@harvey-pc.matrox.com> (raw)
In-Reply-To: <20121108185942.GC28118@parrot.com>

On Thu, Nov 08, 2012 at 07:59:42PM +0100, Ivan Djelic wrote:
> On Thu, Nov 08, 2012 at 03:21:25PM +0000, Christopher Harvey wrote:
> (...) 
> > We had BCH8 code running, but it wasn't enough. The main reason we
> > switched away from host side ECC was because we were getting bitflips
> > within the ECC codeword data itself.
> 
> But the ECC bytes are part of the BCH codeword, therefore I don't understand
> what the issue could be ? Are you sure bitflips were not in some unprotected
> OOB area ?

Ok, the ECC bytes I had were stored in the OOB area and were
unprotected. Any bit flips in the OOB area was a disaster. This was
coming from a heavily modified forked kernel that had BCH8 bugs in the
past. For example, I had to fix this one before the patch came out:
http://arago-project.org/git/projects/linux-omap3.git?p=projects/linux-omap3.git;a=commitdiff;h=adc46d691d745604da1197d154fe712e10ec468d;hp=9e78267ed6302537474489e88bd59827315db15b
I can't explain why this implementation fails on ECC byte corruption.

-Chris

  reply	other threads:[~2012-11-08 19:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-29 20:42 state of support for "external ECC hardware" Christopher Harvey
2012-11-08 11:02 ` Gerlando Falauto
2012-11-08 15:21   ` Christopher Harvey
2012-11-08 16:32     ` Gerlando Falauto
2012-11-08 16:37       ` Gerlando Falauto
2012-11-08 17:03         ` Christopher Harvey
2012-11-08 17:02       ` Christopher Harvey
2012-11-08 19:07       ` Ivan Djelic
2012-11-09  8:46       ` Ricard Wanderlof
2012-11-12 17:19         ` Gerlando Falauto
2012-11-12 17:35           ` Ivan Djelic
2012-11-12 17:39             ` Gerlando Falauto
2012-11-12 18:52               ` Ivan Djelic
2012-11-14 10:12                 ` Gerlando Falauto
2012-11-14 13:24                   ` Angus CLARK
2012-11-14 14:48                     ` Matthieu CASTET
2012-11-14 20:22                     ` Ivan Djelic
2012-11-20 11:13         ` Calvin Johnson
2012-11-20 11:35           ` Gerlando Falauto
2012-11-20 12:12             ` Calvin Johnson
2012-11-20 16:16           ` Ricard Wanderlof
2012-11-08 18:59     ` Ivan Djelic
2012-11-08 19:22       ` Christopher Harvey [this message]
2012-11-08 19:33         ` Ivan Djelic
2012-11-08 18:04   ` Ivan Djelic
2012-11-14 10:59 ` Angus CLARK

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121108192250.GU2389@harvey-pc.matrox.com \
    --to=charvey@matrox.com \
    --cc=Holger.Brunck@keymile.com \
    --cc=gerlando.falauto@keymile.com \
    --cc=ivan.djelic@parrot.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=stefan.bigler@keymile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.