All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@canonical.com>
To: Tao Ma <tm@tao.ma>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: [Acked] [PATCH V2 3/5] checkpatch: Remove reference to feature-removal-schedule.txt.
Date: Fri, 9 Nov 2012 09:55:28 +0000	[thread overview]
Message-ID: <20121109095528.GP3066@dm> (raw)
In-Reply-To: <1352425092-2568-1-git-send-email-tm@tao.ma>

On Fri, Nov 09, 2012 at 09:38:12AM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> In 9c0ece069, Linus removes feature-removal-schedule.txt from Documentation,
> but there is still some reference to this file. So remove them.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andy Whitcroft <apw@canonical.com>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
> ---
>  scripts/checkpatch.pl |   37 -------------------------------------
>  1 files changed, 0 insertions(+), 37 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 21a9f5d..b56c5e0 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -352,27 +352,6 @@ sub deparenthesize {
>  
>  $chk_signoff = 0 if ($file);
>  
> -my @dep_includes = ();
> -my @dep_functions = ();
> -my $removal = "Documentation/feature-removal-schedule.txt";
> -if ($tree && -f "$root/$removal") {
> -	open(my $REMOVE, '<', "$root/$removal") ||
> -				die "$P: $removal: open failed - $!\n";
> -	while (<$REMOVE>) {
> -		if (/^Check:\s+(.*\S)/) {
> -			for my $entry (split(/[, ]+/, $1)) {
> -				if ($entry =~ m@include/(.*)@) {
> -					push(@dep_includes, $1);
> -
> -				} elsif ($entry !~ m@/@) {
> -					push(@dep_functions, $entry);
> -				}
> -			}
> -		}
> -	}
> -	close($REMOVE);
> -}
> -
>  my @rawlines = ();
>  my @lines = ();
>  my $vname;
> @@ -3181,22 +3160,6 @@ sub process {
>  			}
>  		}
>  
> -# don't include deprecated include files (uses RAW line)
> -		for my $inc (@dep_includes) {
> -			if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
> -				ERROR("DEPRECATED_INCLUDE",
> -				      "Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
> -			}
> -		}
> -
> -# don't use deprecated functions
> -		for my $func (@dep_functions) {
> -			if ($line =~ /\b$func\b/) {
> -				ERROR("DEPRECATED_FUNCTION",
> -				      "Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
> -			}
> -		}
> -
>  # no volatiles please
>  		my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
>  		if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
> -- 
> 1.7.0.4
> 

Looks sane and cirtainly if the file is gone we are gaining nothing with
this code.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw

  reply	other threads:[~2012-11-09  9:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08 13:46 [PATCH 0/5] Remove all the reference to feature-removal-schedule Tao Ma
2012-11-08 13:50 ` [PATCH 1/5] Documentation: Remove reference to feature-removal-schedule.txt Tao Ma
2012-11-08 13:50   ` [PATCH 2/5] kernel: " Tao Ma
2012-11-08 13:50   ` [PATCH 3/5] checkpatch: " Tao Ma
2012-11-08 17:47     ` Andy Whitcroft
2012-11-09  1:38       ` [PATCH V2 " Tao Ma
2012-11-09  9:55         ` Andy Whitcroft [this message]
2012-11-08 13:50   ` [PATCH 4/5] sound: " Tao Ma
2012-11-08 13:50   ` [PATCH 5/5] drivers: " Tao Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121109095528.GP3066@dm \
    --to=apw@canonical.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tm@tao.ma \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.