All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: helight <helight@126.com>
Cc: linux-kernel@vger.kernel.org, lrg@ti.com
Subject: Re: [PATCH] fix build waring: drivers/regulator/core.c: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized]
Date: Fri, 9 Nov 2012 11:03:29 +0000	[thread overview]
Message-ID: <20121109110329.GA23807@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <73729ce5.abaa.13ae480da6d.Coremail.helight@126.com>

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

On Fri, Nov 09, 2012 at 05:29:40PM +0800, helight wrote:

> -   unsigned int val;
>     int ret;
> +   unsigned int val = 0;

This sort of change is really not at all helpful, we should be making
sure that whatever path should be initialising the value but isn't does
so, just initialising at declaration means that if the compiler has
spotted a genuine error we won't fix it.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2012-11-09 11:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09  9:29 [PATCH] fix build waring: drivers/regulator/core.c: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized] helight
2012-11-09 11:03 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121109110329.GA23807@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=helight@126.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.