From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/9] ARM: dts: support pinctrl single in pxa910
Date: Fri, 9 Nov 2012 14:48:21 -0800 [thread overview]
Message-ID: <20121109224821.GA6801@atomide.com> (raw)
In-Reply-To: <1352301582-12244-5-git-send-email-haojian.zhuang@gmail.com>
Hi,
To clarify my binding change comment for the generic pinconf
support, here's an example.
We need to move pinctrl-single pinconf properties here for
each pin group:
* Haojian Zhuang <haojian.zhuang@gmail.com> [121107 07:21]:
> + uart1_pins: pinmux_uart1_pins {
> + pinctrl-single,pins = <
> + 0x198 0x6 /* GPIO47_UART1_RXD */
> + 0x19c 0x6 /* GPIO48_UART1_TXD */
> + >;
> + pinctrl-single,power-source = <0x2>;
> + pinctrl-single,bias = <0x6>;
pinctrl-single,power-source-mask = <0x1800>;
pinctrl-single,bias-mask = <0xe000>;
pinctrl-single,bias-disable = <0>;
pinctrl-single,bias-pull-down = <0xa000>;
pinctrl-single,bias-pull-up = <0xc000>;
> + };
> --- a/arch/arm/boot/dts/pxa910.dtsi
> +++ b/arch/arm/boot/dts/pxa910.dtsi
> @@ -54,6 +54,80 @@
> reg = <0xd4000000 0x00200000>;
> ranges;
>
> + pmx: pinmux at d401e000 {
> + compatible = "pinconf-single";
> + reg = <0xd401e000 0x0330>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + pinctrl-single,register-width = <32>;
> + pinctrl-single,function-mask = <7>;
And then..
> + pinctrl-single,power-source-mask = <0x1800>;
> + pinctrl-single,bias-mask = <0xe000>;
> + pinctrl-single,bias-disable = <0>;
> + pinctrl-single,bias-pull-down = <0xa000>;
> + pinctrl-single,bias-pull-up = <0xc000>;
> + pinctrl-single,input-schmitt-mask = <0x70>;
..remove these from here. Otherwise pinctrl-single,bits type controllers
won't be able to use the pinconf functions as we can have multiple pins
supported in a single register.
Regards,
Tony
next prev parent reply other threads:[~2012-11-09 22:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 15:19 [PATCH v4 0/9] use pinctrl-single in arch mmp Haojian Zhuang
2012-11-07 15:19 ` [PATCH v4 1/9] ARM: mmp: select pinctrl driver Haojian Zhuang
2012-11-08 1:38 ` Tony Lindgren
2012-11-10 14:53 ` Haojian Zhuang
2012-11-13 13:37 ` Linus Walleij
2012-11-07 15:19 ` [PATCH v4 2/9] pinctrl: single: support gpio request and free Haojian Zhuang
2012-11-07 22:27 ` Tony Lindgren
2012-11-13 13:07 ` Linus Walleij
2012-11-13 17:34 ` Tony Lindgren
2012-11-14 1:44 ` Haojian Zhuang
2012-11-07 15:19 ` [PATCH v4 3/9] pinctrl: single: support pinconf generic Haojian Zhuang
2012-11-08 0:25 ` Tony Lindgren
2012-11-08 22:55 ` Tony Lindgren
2012-11-08 23:13 ` Tony Lindgren
2012-11-09 21:53 ` Tony Lindgren
2012-11-07 15:19 ` [PATCH v4 4/9] ARM: dts: support pinctrl single in pxa910 Haojian Zhuang
2012-11-09 22:48 ` Tony Lindgren [this message]
2012-11-10 5:37 ` Haojian Zhuang
2012-11-10 20:04 ` Tony Lindgren
2012-11-07 15:19 ` [PATCH v4 5/9] document: devicetree: bind pinconf with pin-single Haojian Zhuang
2012-11-08 1:37 ` Tony Lindgren
2012-11-12 20:37 ` Stephen Warren
2012-11-15 8:27 ` Haojian Zhuang
2012-11-15 8:30 ` Haojian Zhuang
2012-11-07 15:19 ` [PATCH v4 6/9] tty: pxa: configure pin Haojian Zhuang
2012-11-07 15:19 ` [PATCH v4 7/9] i2c: pxa: use devm_kzalloc Haojian Zhuang
2012-11-07 15:19 ` [PATCH v4 8/9] i2c: pxa: configure pinmux Haojian Zhuang
2012-11-07 15:19 ` [PATCH v4 9/9] pinctrl: single: dump pinmux register value Haojian Zhuang
2012-11-08 1:25 ` Tony Lindgren
2012-11-13 13:08 ` Linus Walleij
2012-11-13 17:34 ` Tony Lindgren
2012-11-14 1:45 ` Haojian Zhuang
2012-11-15 14:11 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121109224821.GA6801@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.