All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	spear-devel@list.st.com
Subject: Re: [PATCH 2/3] input: stmpe-ts: Use devm_*() routines
Date: Sat, 10 Nov 2012 00:00:09 -0800	[thread overview]
Message-ID: <20121110080009.GA12015@core.coreip.homeip.net> (raw)
In-Reply-To: <CAKohpomC1KTLk=UVim4gdYhJ5kngTZHOUvUgckD75AVH1w+FHw@mail.gmail.com>

Hi Viresh,

On Fri, Nov 09, 2012 at 10:34:35PM +0530, Viresh Kumar wrote:
> On 9 November 2012 20:57, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > This patch frees stmpe-ts driver from tension of freeing resources :)
> > devm_* derivatives of multiple routines are used while allocating resources,
> > which would be freed automatically by kernel.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Fixup:
> 
> commit dda6d45808d65aaf8b0d4153e7a418b255365818
> Author: Viresh Kumar <viresh.kumar@linaro.org>
> Date:   Fri Nov 9 22:28:26 2012 +0530
> 
>     fixup! input: stmpe-ts: Use devm_*() routines
> ---
>  drivers/input/touchscreen/stmpe-ts.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/stmpe-ts.c
> b/drivers/input/touchscreen/stmpe-ts.c
> index 9896095..f2cb15d 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -344,8 +344,6 @@ static int __devexit stmpe_ts_remove(struct
> platform_device *pdev)

Sometimes your mailer does wrap long lines, please make sure to turn it
off for patches.

There is no need to resend this one.

Thanks.

-- 
Dmitry

  reply	other threads:[~2012-11-10  8:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 15:27 [PATCH 1/3] input: stmpe-keyboard: Use devm_*() routines Viresh Kumar
2012-11-09 15:27 ` [PATCH 2/3] input: stmpe-ts: " Viresh Kumar
2012-11-09 17:04   ` Viresh Kumar
2012-11-10  8:00     ` Dmitry Torokhov [this message]
2012-11-10  8:03       ` Viresh Kumar
2012-11-10  8:04         ` Viresh Kumar
2012-11-10  8:12           ` Dmitry Torokhov
2012-11-10  8:15           ` Hannes Frederic Sowa
2012-11-09 15:27 ` [PATCH 3/3] input:stmpe-ts:Initialize the phys field for input device Viresh Kumar
2012-11-20  6:58   ` Viresh Kumar
2012-11-20  7:47     ` Dmitry Torokhov
2012-11-20  7:57       ` Viresh Kumar
2012-11-09 16:45 ` [PATCH 1/3] input: stmpe-keyboard: Use devm_*() routines Dmitry Torokhov
2012-11-09 17:03   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121110080009.GA12015@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spear-devel@list.st.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.