From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Update load-detect failure paths for modeset-rework Date: Sat, 10 Nov 2012 14:46:32 +0100 Message-ID: <20121110134632.GG5854@phenom.ffwll.local> References: <1352154308-12441-1-git-send-email-chris@chris-wilson.co.uk> <1352154308-12441-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C3509E92B for ; Sat, 10 Nov 2012 05:45:19 -0800 (PST) Received: by mail-ea0-f177.google.com with SMTP id n13so1821271eaa.36 for ; Sat, 10 Nov 2012 05:45:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <1352154308-12441-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Nov 05, 2012 at 10:25:08PM +0000, Chris Wilson wrote: > After the rework, intel_set_mode() became a little better behaved in > restoring the current mode if we failed to apply the requested modeline. > However, the failure path for load-detect would clobber the existing > state, leading to an oops during BIOS takeover on older machines. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter Both patches applied to dinq. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch