From: Stephen Hemminger <shemminger@vyatta.com>
To: Andreas Henriksson <andreas@fatal.se>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH/RFC] iproute2: drop libresolv
Date: Mon, 12 Nov 2012 08:51:15 -0800 [thread overview]
Message-ID: <20121112085115.04ea916c@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20121110122209.GA15100@amd64.fatal.se>
On Sat, 10 Nov 2012 13:22:10 +0100
Andreas Henriksson <andreas@fatal.se> wrote:
> Hello!
>
> While building the iproute package in Debian I get warnings from
> package helpers like this:
>
> dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/iproute/sbin/tc debian/iproute/usr/bin/lnstat debian/iproute/bin/ip debian/iproute/bin/ss debian/iproute/sbin/bridge debian/iproute/sbin/rtmon were not linked against libresolv.so.2 (they use none of the library's symbols)
>
> The -lresolv in ./Makefile seems to come from pre-historic times (before
> iproute2 git history, possibly from libc5/pre-glibc days).
> I couldn't find out if/why there was any reason for linking to libresolv.
> Does anyone know if there are any valid reasons for keeping it still?
>
> If not, I'd be happy to see it go.... while at it I also removed includes
> of <resolv.h> which I also couldn't find any reason for, but this is
> just an added bonus of the patch (and there are probably more unneeded
> includes that could be dropped in the same sources).
>
>
> Signed-off-by: Andreas Henriksson <andreas@fatal.se>
>
Makes sense, applied.
prev parent reply other threads:[~2012-11-12 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 12:22 [PATCH/RFC] iproute2: drop libresolv Andreas Henriksson
2012-11-12 16:51 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121112085115.04ea916c@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=andreas@fatal.se \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.