From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] Fix locking in
	tools/hotplug/Linux/locking.sh
Date: Mon, 12 Nov 2012 19:07:38 +0100
Message-ID: <20121112180738.GA26672@aepfle.de>
References: <1352469371-15457-1-git-send-email-jajcus@jajcus.net>
	<1352738557.27833.302.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1352738557.27833.302.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Jacek Konieczny <jajcus@jajcus.net>
List-Id: xen-devel@lists.xenproject.org

On Mon, Nov 12, Ian Campbell wrote:

> On Fri, 2012-11-09 at 13:56 +0000, Jacek Konieczny wrote:
> > The claim_lock() function would fail in the perl code with:
> > 
> >   Invalid argument at -e line 2.
> > 
> > because the Perl snippet opens for reading the file descriptor, which
> > was earlier opened for write (append).
> 
> Looks plausible to me.
> 
> How does this interact with the 
>         eval "exec $_lockfd<&-"
> which Olaf added in 26079:b3b03536789a ? I suppose close is close and
> <&- and >&- or even <>&- are equivalent?

I did not see the perl error, in what environment did you notice this
error?

Olaf