All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: "Franklin S. Cooper Jr" <fcooperjr27@gmail.com>
Cc: meta-arago@arago-project.org, "Franklin S. Cooper Jr" <fcooper@ti.com>
Subject: Re: [PATCH] meta-toolchain-arago: de-bashify
Date: Mon, 12 Nov 2012 18:20:29 -0500	[thread overview]
Message-ID: <20121112232029.GB8900@denix.org> (raw)
In-Reply-To: <1352759598-5183-1-git-send-email-fcooper@ti.com>

On Mon, Nov 12, 2012 at 04:33:18PM -0600, Franklin S. Cooper Jr wrote:
> * Replacing "echo -e" with "printf".
> * This mimics a previous de-bashify patch applied to this same recipe.
> 
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>

How is it different from this:
http://arago-project.org/git/?p=meta-arago.git;a=commitdiff;h=7f47dbad47a44c8d16c12139260a00b80d603e71

I'd suggest you update your tree to the latest code base...

> ---
>  .../recipes-core/meta/meta-toolchain-arago.bb      |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> index 09996d6..3d3fb0d 100644
> --- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> +++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> @@ -4,7 +4,7 @@ TOOLCHAIN_OUTPUTNAME ?= "${SDK_NAME}-${ARMPKGARCH}-${TARGET_OS}-sdk-${SDK_ARCH}"
>  
>  require recipes-core/meta/meta-toolchain.bb
>  
> -PR = "r7"
> +PR = "r8"
>  
>  SDKTARGETSYSROOT = "${SDKPATH}/${ARAGO_TARGET_SYS}"
>  
> @@ -54,15 +54,15 @@ toolchain_create_sdk_env_script () {
>  	echo 'export OECORE_ACLOCAL_OPTS="-I $SDK_PATH/usr/share/aclocal"' >> $script
>  	echo 'export OECORE_DISTRO_VERSION="${DISTRO_VERSION}"' >> $script
>  	echo 'export OECORE_SDK_VERSION="${SDK_VERSION}"' >> $script
> -    echo -e 'export CPP="\x24{TARGET_PREFIX}gcc -E"' >> $script
> -    echo -e 'export NM=\x24{TARGET_PREFIX}nm' >> $script
> -    echo -e 'export RANLIB=\x24{TARGET_PREFIX}ranlib' >> $script
> -    echo -e 'export OBJCOPY=\x24{TARGET_PREFIX}objcopy' >> $script
> -    echo -e 'export STRIP=\x24{TARGET_PREFIX}strip' >> $script
> -    echo -e 'export AS=\x24{TARGET_PREFIX}as' >> $script
> -    echo -e 'export AR=\x24{TARGET_PREFIX}ar' >> $script
> -    echo -e 'export OBJDUMP=\x24{TARGET_PREFIX}objdump' >> $script
> -    echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
> +	printf 'export CPP="\x24{TARGET_PREFIX}gcc -E"\n' >> $script
> +	printf 'export NM=\x24{TARGET_PREFIX}nm\n' >> $script
> +	printf 'export RANLIB=\x24{TARGET_PREFIX}ranlib\n' >> $script
> +	printf 'export OBJCOPY=\x24{TARGET_PREFIX}objcopy\n' >> $script
> +	printf 'export STRIP=\x24{TARGET_PREFIX}strip\n' >> $script
> +	printf 'export AS=\x24{TARGET_PREFIX}as\n' >> $script
> +	printf 'export AR=\x24{TARGET_PREFIX}ar\n' >> $script
> +	printf 'export OBJDUMP=\x24{TARGET_PREFIX}objdump\n' >> $script
> +	echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
>  }
>  
>  populate_sdk_ipk_append () {
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> 


  reply	other threads:[~2012-11-12 23:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12 22:33 [PATCH] meta-toolchain-arago: de-bashify Franklin S. Cooper Jr
2012-11-12 23:20 ` Denys Dmytriyenko [this message]
2012-11-12 23:40   ` Cooper Jr., Franklin
2012-11-12 23:49     ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121112232029.GB8900@denix.org \
    --to=denis@denix.org \
    --cc=fcooper@ti.com \
    --cc=fcooperjr27@gmail.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.