All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Al Viro <viro@zeniv.linux.org.uk>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Pavel Emelyanov <xemul@parallels.com>,
	James Bottomley <jbottomley@parallels.com>,
	Matthew Helsley <matt.helsley@gmail.com>,
	aneesh.kumar@linux.vnet.ibm.com, bfields@fieldses.org
Subject: Re: [patch 3/7] fs, notify: Add file handle entry into inotify_inode_mark
Date: Mon, 12 Nov 2012 23:40:01 -0800	[thread overview]
Message-ID: <20121112234001.009b2ae3.akpm@linux-foundation.org> (raw)
In-Reply-To: <20121113072057.GC6511@moon>

On Tue, 13 Nov 2012 11:20:57 +0400 Cyrill Gorcunov <gorcunov@openvz.org> wrote:

> > >  struct inotify_inode_mark {
> > >  	struct fsnotify_mark fsn_mark;
> > >  	int wd;
> > > +#ifdef INOTIFY_USE_FHANDLE
> > > +	__u8 fhandle[sizeof(struct file_handle) + MAX_HANDLE_SZ];
> > > +#endif
> > >  };
> > 
> > Whoa.  This adds 128+8 bytes to the inotify_inode_mark.  That's a lot of
> > bloat, and there can be a lot of inotify_inode_mark's in the system?
> 
> Yes, that's why it's not turned on by default, only if is c/r turned on.
> iirc I've been said that usually only about 40 bytes is used (in the tests
> I met only 8 bytes). Letme re-check all things.

The question is, how many `struct inotify_inode_mark's are instantiated
system-wide?  Could be millions?

Dumb question: do we really need inotify_inode_mark.fhandle at all? 
What prevents us from assembling this info on demand when ->show_fdinfo() is
called?



  reply	other threads:[~2012-11-13  7:40 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12 10:14 [patch 0/7] Providing additional information in fdinfo sufficient for c/r Cyrill Gorcunov
2012-11-12 10:14 ` [patch 1/7] procfs: Add ability to plug in auxiliary fdinfo providers Cyrill Gorcunov
2012-11-13  0:40   ` Andrew Morton
2012-11-13  7:03     ` Cyrill Gorcunov
2012-11-12 10:14 ` [patch 2/7] fs, exportfs: Escape nil dereference if no s_export_op present Cyrill Gorcunov
2012-11-12 10:14 ` [patch 3/7] fs, notify: Add file handle entry into inotify_inode_mark Cyrill Gorcunov
2012-11-13  0:55   ` Andrew Morton
2012-11-13  7:20     ` Cyrill Gorcunov
2012-11-13  7:40       ` Andrew Morton [this message]
2012-11-13  8:00         ` Cyrill Gorcunov
2012-11-13  8:19           ` David Rientjes
2012-11-13  8:29             ` Cyrill Gorcunov
     [not found]               ` <2910785.4Vm74eFJyi@deuteros>
2012-11-13 14:40                 ` Cyrill Gorcunov
2012-11-13 15:02                   ` Tvrtko Ursulin
2012-11-13 15:28                     ` Cyrill Gorcunov
2012-11-14  9:20                       ` Tvrtko Ursulin
2012-11-14  9:38                         ` Cyrill Gorcunov
2012-11-14  9:50                           ` Tvrtko Ursulin
2012-11-14  9:58                             ` Cyrill Gorcunov
2012-11-14 10:08                               ` Tvrtko Ursulin
2012-11-14 10:13                                 ` Pavel Emelyanov
2012-11-14 10:38                                   ` Tvrtko Ursulin
2012-11-14 10:46                                     ` Pavel Emelyanov
2012-11-14 10:54                                       ` Tvrtko Ursulin
2012-11-14 10:56                                         ` Pavel Emelyanov
2012-11-14 11:03                                           ` Cyrill Gorcunov
2012-11-14 11:12                                           ` Tvrtko Ursulin
2012-11-14 12:45                                       ` J. Bruce Fields
2012-11-14 13:03                                         ` Cyrill Gorcunov
2012-11-14 13:26                                           ` J. Bruce Fields
2012-11-14 13:32                                             ` Cyrill Gorcunov
2012-11-13 22:38           ` Andrew Morton
2012-11-14  6:46             ` Cyrill Gorcunov
2012-11-14 10:10               ` Pavel Emelyanov
2012-11-14 10:13                 ` Cyrill Gorcunov
2012-11-12 10:14 ` [patch 4/7] fs, notify: Add procfs fdinfo helper v4 Cyrill Gorcunov
2012-11-13  1:00   ` Andrew Morton
2012-11-13  7:22     ` Cyrill Gorcunov
2012-11-12 10:14 ` [patch 5/7] fs, eventfd: Add procfs fdinfo helper Cyrill Gorcunov
2012-11-12 10:14 ` [patch 6/7] fs, epoll: Add procfs fdinfo helper v2 Cyrill Gorcunov
2012-11-12 10:14 ` [patch 7/7] fdinfo: Show sigmask for signalfd fd v2 Cyrill Gorcunov
2012-11-13  1:05   ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2012-09-12 21:29 [patch 0/7] auxiliary fdinfo, new round Cyrill Gorcunov
2012-09-12 21:29 ` [patch 3/7] fs, notify: Add file handle entry into inotify_inode_mark Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121112234001.009b2ae3.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=adobriyan@gmail.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=bfields@fieldses.org \
    --cc=gorcunov@openvz.org \
    --cc=jbottomley@parallels.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.helsley@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.