Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Initialize lockdep class keys for hashes

[Antonio Quartulli <ordex@autistici.org>]

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Tue, Nov 13, 2012 at 09:06:22AM +0100, Antonio Quartulli wrote:
> On Sat, Nov 10, 2012 at 11:00:32AM +0100, Antonio Quartulli wrote:
> > Different hashes have the same class key key because they get
> > initialised with the same one. For this reason lockdep can create
> > false warning when they are used recursively.
> > 
> > Re-initialise the key for each hash after the invocation to hash_new()
> > to avoid this problem.
> > 
> > Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> 
> I was thinking...instead of creating such "a free noise" in udev, we may want to
> add a configuration facility so that the user can choose which uevents to enable
> and which not..
> 
> If we don't do so batman-adv will start throwing uevents even if not needed.
> 
> Please, drop this patch. We need some more code here :-)

Sorry, the message above was meant for another patch -.-



-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]