From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Liam Girdwood <lrg@ti.com>, Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 2/3] regulator: threat regulators with constant volatage as fixed
Date: Tue, 13 Nov 2012 18:00:09 +0900 [thread overview]
Message-ID: <20121113090007.GS18224@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1352796533-12350-3-git-send-email-m.szyprowski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
On Tue, Nov 13, 2012 at 09:48:52AM +0100, Marek Szyprowski wrote:
> Some drivers has additional logic for fixed regulators. Let regulator core
> to threat regulators which cannot change their voltage due to applied
YM "treat".
> + if (rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE)
> + return rdev->desc->n_voltages ? : -EINVAL;
Please don't perpetuate the use of ? : as it's not a triumph of
legibility (even worse than the regular ternery operator). I realise
that the original code did this but there's no need to carry on doing
the same thing.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-13 9:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 8:48 [PATCH 0/3] Fix fixed regulators support Marek Szyprowski
2012-11-13 8:48 ` [PATCH 1/3] regulator: fix voltage check in regulator_is_supported_voltage() Marek Szyprowski
2012-11-13 9:01 ` Mark Brown
2012-11-13 8:48 ` [PATCH 2/3] regulator: threat regulators with constant volatage as fixed Marek Szyprowski
2012-11-13 9:00 ` Mark Brown [this message]
2012-11-13 9:35 ` [PATCH v2] regulator: treat " Marek Szyprowski
2012-11-13 9:42 ` Mark Brown
2012-11-13 9:49 ` [PATCH v3] " Marek Szyprowski
2012-11-14 2:01 ` Mark Brown
2012-11-20 13:20 ` Marek Szyprowski
2012-11-13 8:48 ` [PATCH 3/3] mmc: sdhci: apply voltage range check only for non-fixed regulators Marek Szyprowski
2012-11-13 12:45 ` Chris Ball
2012-11-13 13:32 ` [PATCH v2] " Marek Szyprowski
2012-11-13 13:45 ` Chris Ball
2012-11-13 14:09 ` Marek Szyprowski
2012-11-13 14:14 ` Chris Ball
2012-11-13 21:23 ` Philip Rakity
2012-11-20 8:42 ` Marek Szyprowski
2012-11-14 1:10 ` [PATCH 3/3] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113090007.GS18224@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.