diff for duplicates of <20121113105327.GC27797@pengutronix.de> diff --git a/a/1.txt b/N1/1.txt index d00cc9c..134f2e0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -34,7 +34,7 @@ On Mon, Nov 12, 2012 at 11:00:37PM +0400, Alexey Klimov wrote: > > +++ b/Documentation/devicetree/bindings/video/display-timings.txt > > @@ -0,0 +1,107 @@ > > +display-timings bindings -> > +============ +> > +======================== > > + > > +display-timings-node > > +-------------------- @@ -77,7 +77,8 @@ On Mon, Nov 12, 2012 at 11:00:37PM +0400, Alexey Klimov wrote: > > +The parameters are defined as > > + > > +struct display_timing -> > +==========> > + +> > +===================== +> > + > > + +----------+---------------------------------------------+----------+-------+ > > + | | ↑ | | | > > + | | |vback_porch | | | @@ -217,11 +218,11 @@ On Mon, Nov 12, 2012 at 11:00:37PM +0400, Alexey Klimov wrote: > > + } > > + > > + cells = length / sizeof(u32); -> > + if (cells = 1) { +> > + if (cells == 1) { > > + ret = of_property_read_u32(np, name, &result->typ); > > + result->min = result->typ; > > + result->max = result->typ; -> > + } else if (cells = 3) { +> > + } else if (cells == 3) { > > + ret = of_property_read_u32_array(np, name, &result->min, cells); > > + } else { > > + pr_err("%s: illegal timing specification in %s\n", __func__, name); @@ -316,7 +317,8 @@ On Mon, Nov 12, 2012 at 11:00:37PM +0400, Alexey Klimov wrote: > > + if (!disp->timings) > > + return -ENOMEM; > -> Could you please check return values here ^^^ and above "disp > kzalloc(sizeof(*disp), GFP_KERNEL);" ? +> Could you please check return values here ^^^ and above "disp = +> kzalloc(sizeof(*disp), GFP_KERNEL);" ? > May be it's better to return NULL instead of -ENOMEM and put error message? > I will do that along with the memory leak fixes. diff --git a/a/content_digest b/N1/content_digest index b9d537c..05acace 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0CALW4P+JmyEnnxpC8AuJ1-mPG-Rw0XEyZFogeVaNuw5omdH5-CA@mail.gmail.com\0" "From\0Steffen Trumtrar <s.trumtrar@pengutronix.de>\0" "Subject\0Re: [PATCH v8 2/6] video: add of helper for videomode\0" - "Date\0Tue, 13 Nov 2012 10:53:27 +0000\0" + "Date\0Tue, 13 Nov 2012 11:53:27 +0100\0" "To\0Alexey Klimov <klimov.linux@gmail.com>\0" "Cc\0devicetree-discuss@lists.ozlabs.org" Philipp Zabel <p.zabel@pengutronix.de> @@ -55,7 +55,7 @@ "> > +++ b/Documentation/devicetree/bindings/video/display-timings.txt\n" "> > @@ -0,0 +1,107 @@\n" "> > +display-timings bindings\n" - "> > +============\n" + "> > +========================\n" "> > +\n" "> > +display-timings-node\n" "> > +--------------------\n" @@ -98,7 +98,8 @@ "> > +The parameters are defined as\n" "> > +\n" "> > +struct display_timing\n" - "> > +==========> > +\n" + "> > +=====================\n" + "> > +\n" "> > + +----------+---------------------------------------------+----------+-------+\n" "> > + | | \342\206\221 | | |\n" "> > + | | |vback_porch | | |\n" @@ -238,11 +239,11 @@ "> > + }\n" "> > +\n" "> > + cells = length / sizeof(u32);\n" - "> > + if (cells = 1) {\n" + "> > + if (cells == 1) {\n" "> > + ret = of_property_read_u32(np, name, &result->typ);\n" "> > + result->min = result->typ;\n" "> > + result->max = result->typ;\n" - "> > + } else if (cells = 3) {\n" + "> > + } else if (cells == 3) {\n" "> > + ret = of_property_read_u32_array(np, name, &result->min, cells);\n" "> > + } else {\n" "> > + pr_err(\"%s: illegal timing specification in %s\\n\", __func__, name);\n" @@ -337,7 +338,8 @@ "> > + if (!disp->timings)\n" "> > + return -ENOMEM;\n" "> \n" - "> Could you please check return values here ^^^ and above \"disp > kzalloc(sizeof(*disp), GFP_KERNEL);\" ?\n" + "> Could you please check return values here ^^^ and above \"disp =\n" + "> kzalloc(sizeof(*disp), GFP_KERNEL);\" ?\n" "> May be it's better to return NULL instead of -ENOMEM and put error message?\n" "> \n" "I will do that along with the memory leak fixes.\n" @@ -351,4 +353,4 @@ "Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |\n" Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -3483eb8cc3f105c779ace012d946ac1c3de7ac7a27b2669df6e7e08380baa8f2 +7683e04b0491414f6d43886faabed221ba4660dccb70bb1dfcc32c778caf1777
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.