From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: arizona: Move chip reset to before register patch
Date: Tue, 13 Nov 2012 13:12:19 +0000 [thread overview]
Message-ID: <20121113131219.GA29198@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121113055618.GC18224@opensource.wolfsonmicro.com>
On Tue, Nov 13, 2012 at 02:56:20PM +0900, Mark Brown wrote:
> On Mon, Nov 12, 2012 at 05:56:48PM +0000, Charles Keepax wrote:
> > In the absence of a physical reset line the chip is reset by writing the
> > first register, this was done after the register patch was applied which
> > negates the settings applied in the register patch.
> >
> > This patch moves the reset to take place before the register patch is
> > applied.
>
> No, we should never write to the chip until we have successfully
> identified it. Do a sync or similar instead (we should be triggering
> this very soon afterwards via runtime PM anyway).
In that case I would be inclined to seperate out the chip
identification and the register patch doing the reset in between.
Is this something that would sound reasonable or would you rather
just add a sync after the reset?
next prev parent reply other threads:[~2012-11-13 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 17:56 [PATCH] mfd: arizona: Move chip reset to before register patch Charles Keepax
2012-11-13 5:56 ` Mark Brown
2012-11-13 13:12 ` Charles Keepax [this message]
2012-11-14 1:20 ` Mark Brown
2012-11-14 10:48 ` Charles Keepax
2012-11-14 10:51 ` Mark Brown
2012-11-14 11:31 ` [PATCH v2] mfd: arizona: Sync regcache after reset Charles Keepax
2012-11-14 11:34 ` Mark Brown
2012-11-14 11:45 ` Charles Keepax
2012-11-15 14:55 ` [PATCH v3] " Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113131219.GA29198@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.