From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/i915/i2c: Track users of GMBUS force-bit
Date: Tue, 13 Nov 2012 16:12:26 +0100 [thread overview]
Message-ID: <20121113151225.GS5854@phenom.ffwll.local> (raw)
In-Reply-To: <878va5va6o.fsf@intel.com>
On Tue, Nov 13, 2012 at 04:39:43PM +0200, Jani Nikula wrote:
> On Sat, 10 Nov 2012, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > @@ -583,7 +583,10 @@ void intel_gmbus_force_bit(struct i2c_adapter *adapter, bool force_bit)
> > {
> > struct intel_gmbus *bus = to_intel_gmbus(adapter);
> >
> > - bus->force_bit = force_bit;
> > + bus->force_bit += force_bit ? 1 : -1;
> > + DRM_DEBUG_KMS("%sabling bit-banging on %s. force bit now %d\n",
> > + force_bit ? "dis" : "en", adapter->name,
> > + bus->force_bit);
>
> Reading a dmesg from Chris, I noticed force_bit ? "dis" : "en" is
> backwards.
Thanks for spotting this, rebase out, it never happened.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-11-13 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 15:58 [PATCH] drm/i915/i2c: Track users of GMBUS force-bit Chris Wilson
2012-11-10 20:52 ` Daniel Vetter
2012-11-12 7:37 ` Jani Nikula
2012-11-13 14:39 ` Jani Nikula
2012-11-13 15:12 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113151225.GS5854@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.