From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Pavel Emelyanov <xemul@parallels.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Alexey Dobriyan <adobriyan@gmail.com>,
James Bottomley <jbottomley@parallels.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Matthew Helsley <matt.helsley@gmail.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: + fs-epoll-add-procfs-fdinfo-helper.patch added to -mm tree
Date: Tue, 13 Nov 2012 19:53:13 +0400 [thread overview]
Message-ID: <20121113155313.GU6511@moon> (raw)
In-Reply-To: <20121113145050.GA13691@redhat.com>
On Tue, Nov 13, 2012 at 03:50:50PM +0100, Oleg Nesterov wrote:
> This doesn't look right.
>
> The problem is, the current locking is broken, ->siglock can not serialize
> ->sigmask changes. Just suppose the the child inherits sigfd from parent
> and they both do sys_signalfd4() at the same time.
>
> Nothing really bad can happen, that is why nobody bothers to fix this.
> But this patch makes the thing worse, write_seqcount_begin() must be
> serialized correctly.
Thanks a lot, Oleg! I'll update.
next prev parent reply other threads:[~2012-11-13 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 14:50 + fs-epoll-add-procfs-fdinfo-helper.patch added to -mm tree Oleg Nesterov
2012-11-13 15:53 ` Cyrill Gorcunov [this message]
2012-11-13 16:20 ` Cyrill Gorcunov
2012-11-13 16:49 ` Oleg Nesterov
2012-11-13 17:01 ` Cyrill Gorcunov
2012-11-13 17:14 ` Cyrill Gorcunov
2012-11-13 17:47 ` Oleg Nesterov
2012-11-13 17:53 ` Cyrill Gorcunov
2012-11-13 17:55 ` Oleg Nesterov
-- strict thread matches above, loose matches on Subject: below --
2012-11-13 1:06 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113155313.GU6511@moon \
--to=gorcunov@openvz.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bfields@fieldses.org \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.helsley@gmail.com \
--cc=oleg@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.