From: Samuel Ortiz <sameo@linux.intel.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@avionic-design.de>
Subject: Re: [PATCH] MFD: twl-core: Fix chip ID for the twl6030-pwm module
Date: Tue, 13 Nov 2012 19:59:02 +0100 [thread overview]
Message-ID: <20121113185902.GO27828@sortiz-mobl> (raw)
In-Reply-To: <1351695277-8629-1-git-send-email-peter.ujfalusi@ti.com>
Hi Peter,
On Wed, Oct 31, 2012 at 03:54:37PM +0100, Peter Ujfalusi wrote:
> The correct chip id is 1 since the PWM module is on address 0x49. With the
> current TWL6030_MODULE_ID1 the kernel will crash early since:
> #define TWL6030_MODULE_ID1 0x0E
> and
> static struct twl_client twl_modules[4];
>
> Down in the stack we try to get the module by:
> struct twl_client *twl = &twl_modules[chip];
>
> Which obviously going to do nasty things.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi Samuel,
>
> Can you push this patch to 3.7?
Applied to my for-linus branch. This should make it to 3.7.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-11-13 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 14:54 [PATCH] MFD: twl-core: Fix chip ID for the twl6030-pwm module Peter Ujfalusi
2012-11-01 9:09 ` Tero Kristo
2012-11-12 14:50 ` Peter Ujfalusi
2012-11-13 18:59 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113185902.GO27828@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=t-kristo@ti.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.