From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: lrg@ti.com, ldewangan@nvidia.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Add locked version of regulator_put to avoid deadlock
Date: Wed, 14 Nov 2012 08:25:56 +0900 [thread overview]
Message-ID: <20121113232537.GA27212@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121113163040.GA19089@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Tue, Nov 13, 2012 at 04:30:40PM +0000, Charles Keepax wrote:
> -void regulator_put(struct regulator *regulator)
> +static void __regulator_put_locked(struct regulator *regulator)
Please do follow the coding style of the rest of the code; nothing else
is using __ for private functions.
Please also clarify the changelog - you're not adding a new API here,
you're fiddling about with the internals. Obviously regulator_put() is
always locked, you're just rearranging code inside the core here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-13 23:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 10:34 [PATCH] regulator: core: avoid memory access after freeing it Laxman Dewangan
2012-11-06 11:12 ` Charles Keepax
2012-11-06 11:31 ` Mark Brown
2012-11-13 16:30 ` [PATCH] regulator: core: Add locked version of regulator_put to avoid deadlock Charles Keepax
2012-11-13 17:16 ` Laxman Dewangan
2012-11-13 23:25 ` Mark Brown [this message]
2012-11-14 9:39 ` [PATCH v2] regulator: core: Avoid deadlock when regulator_register fails Charles Keepax
2012-11-14 10:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113232537.GA27212@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.