From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"lrg@ti.com" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver
Date: Wed, 14 Nov 2012 11:45:31 +0900 [thread overview]
Message-ID: <20121114024529.GN4415@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <50A30381.3000609@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On Tue, Nov 13, 2012 at 09:35:45PM -0500, Laxman Dewangan wrote:
> Yes, this is not a good idea, We will need support for wakeup
> without wakeup registers.
> Probably we need to add one more parameter, wake enable to control
> without wake_base.
This does not seem sensible. Why would this be optional if it is
useful? In any case, what you're doing in the driver here is clearly
not the way forward.
> >>There is 2 sets of registers which need to be configure, MASK and
> >>LINE enable.
> >So what does the second one do?
> The MASK register used for updating status register when interrupt
> occurs and LINE register used to pass the status to actual interrupt
> line.
So this sounds like the LINE register is actually the mask register
which is the opposite way around... please describe this stuff in the
comments anyway.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-14 2:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 15:11 [PATCH V3 0/2] tps80031: Add mfd and regulator driver Laxman Dewangan
2012-11-11 15:12 ` [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver Laxman Dewangan
2012-11-12 11:30 ` Guennadi Liakhovetski
2012-11-13 7:46 ` Mark Brown
2012-11-13 17:48 ` Laxman Dewangan
2012-11-14 1:22 ` Mark Brown
2012-11-14 2:35 ` Laxman Dewangan
2012-11-14 2:45 ` Mark Brown [this message]
2012-11-14 3:01 ` Laxman Dewangan
2012-11-14 3:04 ` Mark Brown
2012-11-14 3:51 ` Laxman Dewangan
2012-11-11 15:12 ` [PATCH V3 2/2] regulator: tps80031: add regulator driver for tps80031 Laxman Dewangan
2012-11-12 12:28 ` Guennadi Liakhovetski
2012-11-13 6:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114024529.GN4415@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.