diff for duplicates of <20121114082307.GA31792@elgon.mountain> diff --git a/a/1.txt b/N1/1.txt index 7aab6a9..8728886 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,5 +1,5 @@ '|' has higher precedence than ?:. Since AR5K_PHY_TURBO_MODE is 0x1 and -"AR5K_PHY_TURBO_MODE | (ah->ah_radio = AR5K_RF2425)" is true then we +"AR5K_PHY_TURBO_MODE | (ah->ah_radio == AR5K_RF2425)" is true then we always set turbo to zero. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> @@ -13,13 +13,13 @@ index 0c2dd47..4084b10 100644 @@ -789,9 +789,9 @@ ath5k_hw_nic_wakeup(struct ath5k_hw *ah, struct ieee80211_channel *channel) * (I don't think it supports 44MHz) */ /* On 2425 initvals TURBO_SHORT is not present */ - if (ah->ah_bwmode = AR5K_BWMODE_40MHZ) { + if (ah->ah_bwmode == AR5K_BWMODE_40MHZ) { - turbo = AR5K_PHY_TURBO_MODE | -- (ah->ah_radio = AR5K_RF2425) ? 0 : +- (ah->ah_radio == AR5K_RF2425) ? 0 : - AR5K_PHY_TURBO_SHORT; + turbo = AR5K_PHY_TURBO_MODE; + if (ah->ah_radio != AR5K_RF2425) + turbo |= AR5K_PHY_TURBO_SHORT; } else if (ah->ah_bwmode != AR5K_BWMODE_DEFAULT) { - if (ah->ah_radio = AR5K_RF5413) { - mode |= (ah->ah_bwmode = AR5K_BWMODE_10MHZ) ? + if (ah->ah_radio == AR5K_RF5413) { + mode |= (ah->ah_bwmode == AR5K_BWMODE_10MHZ) ? diff --git a/a/content_digest b/N1/content_digest index 528f3b8..13ad497 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[patch] ath5k: precedence error in ath5k_hw_nic_wakeup()\0" - "Date\0Wed, 14 Nov 2012 08:23:07 +0000\0" + "Date\0Wed, 14 Nov 2012 11:23:07 +0300\0" "To\0Jiri Slaby <jirislaby@gmail.com>\0" "Cc\0Nick Kossifidis <mickflemm@gmail.com>" Luis R. Rodriguez <mcgrof@qca.qualcomm.com> @@ -11,7 +11,7 @@ "\00:1\0" "b\0" "'|' has higher precedence than ?:. Since AR5K_PHY_TURBO_MODE is 0x1 and\n" - "\"AR5K_PHY_TURBO_MODE | (ah->ah_radio = AR5K_RF2425)\" is true then we\n" + "\"AR5K_PHY_TURBO_MODE | (ah->ah_radio == AR5K_RF2425)\" is true then we\n" "always set turbo to zero.\n" "\n" "Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" @@ -25,15 +25,15 @@ "@@ -789,9 +789,9 @@ ath5k_hw_nic_wakeup(struct ath5k_hw *ah, struct ieee80211_channel *channel)\n" " \t\t * (I don't think it supports 44MHz) */\n" " \t\t/* On 2425 initvals TURBO_SHORT is not present */\n" - " \t\tif (ah->ah_bwmode = AR5K_BWMODE_40MHZ) {\n" + " \t\tif (ah->ah_bwmode == AR5K_BWMODE_40MHZ) {\n" "-\t\t\tturbo = AR5K_PHY_TURBO_MODE |\n" - "-\t\t\t\t(ah->ah_radio = AR5K_RF2425) ? 0 :\n" + "-\t\t\t\t(ah->ah_radio == AR5K_RF2425) ? 0 :\n" "-\t\t\t\tAR5K_PHY_TURBO_SHORT;\n" "+\t\t\tturbo = AR5K_PHY_TURBO_MODE;\n" "+\t\t\tif (ah->ah_radio != AR5K_RF2425)\n" "+\t\t\t\tturbo |= AR5K_PHY_TURBO_SHORT;\n" " \t\t} else if (ah->ah_bwmode != AR5K_BWMODE_DEFAULT) {\n" - " \t\t\tif (ah->ah_radio = AR5K_RF5413) {\n" - " \t\t\t\tmode |= (ah->ah_bwmode = AR5K_BWMODE_10MHZ) ?" + " \t\t\tif (ah->ah_radio == AR5K_RF5413) {\n" + " \t\t\t\tmode |= (ah->ah_bwmode == AR5K_BWMODE_10MHZ) ?" -4cda18d266696418b32e49e4b7107e0aa71680bfc2d5215211a337c01c33d59d +858a6dae892fb550c0a1374cb785f01c73420ff42382b66131f0529a36b5948b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.