From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] hfsplus: avoid crash on failed block map free
Date: Wed, 14 Nov 2012 12:24:48 +0100 [thread overview]
Message-ID: <20121114112448.GA27431@lst.de> (raw)
In-Reply-To: <20121113143444.f8d4bbc3.akpm@linux-foundation.org>
On Tue, Nov 13, 2012 at 02:34:44PM -0800, Andrew Morton wrote:
> It looks better than what we currently have!
>
> The code is missing a flush_dcache_page()? We should have one in there
> after the CPU has modified userspace-mappable page contents.
>
>
> btw, I still have question marks over your earlier patches:
>
> hfsplus-add-on-disk-layout-declarations-related-to-attributes-tree.patch
> hfsplus-add-functionality-of-manipulating-by-records-in-attributes-tree.patch
> hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes.patch
> hfsplus-add-support-of-manipulation-by-attributes-file.patch
> hfsplus-add-support-of-manipulation-by-attributes-file-checkpatch-fixes.patch
> hfsplus-code-style-fixes-reworked-support-of-extended-attributes.patch
>
> Christoph sounded unhappy, but the review discussion petered out?
It really just needs the xattr namespace fixed. JFS is a good model for
how to expose the legacy OS/2 attributes that are lacking a namespace prefix.
next prev parent reply other threads:[~2012-11-14 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 9:31 [PATCH v2] hfsplus: avoid crash on failed block map free Vyacheslav Dubeyko
2012-11-13 22:34 ` Andrew Morton
2012-11-14 11:24 ` Christoph Hellwig [this message]
2012-11-15 7:07 ` Vyacheslav Dubeyko
2012-11-15 9:17 ` Christoph Hellwig
2012-11-15 9:31 ` Vyacheslav Dubeyko
2012-11-14 12:50 ` Vyacheslav Dubeyko
2012-12-18 22:47 ` Andrew Morton
2012-12-19 6:26 ` Vyacheslav Dubeyko
2012-12-19 6:29 ` Andrew Morton
2012-12-19 6:42 ` Vyacheslav Dubeyko
2012-12-19 14:09 ` Christoph Hellwig
2012-12-19 14:15 ` Vyacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114112448.GA27431@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.