From: Alban Bedel <alban.bedel@avionic-design.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Alban Bedel <alban.bedel@avionic-design.de>
Subject: Re: [PATCH] Input: tca8418-keypad - switch to use managed resources
Date: Wed, 14 Nov 2012 11:47:37 +0100 [thread overview]
Message-ID: <20121114114737.16e33404@avionic-0020.adnet.avionic-design.de> (raw)
In-Reply-To: <20121108170932.GA28478@core.coreip.homeip.net>
On Thu, 8 Nov 2012 09:09:34 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> Let's switch to using devm_*() interfaces to manage our resources, thus will
> simplify error unwinding a bit.
>
LGTM but I would suggest splitting it with the "niceness" changes
(client->dev to dev, etc) in one patch and the devm conversion in
another.
Alban
prev parent reply other threads:[~2012-11-14 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 17:09 [PATCH] Input: tca8418-keypad - switch to use managed resources Dmitry Torokhov
2012-11-14 10:47 ` Alban Bedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114114737.16e33404@avionic-0020.adnet.avionic-design.de \
--to=alban.bedel@avionic-design.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.