All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Kamil Iskra <kamil@iskra.name>,
	linux-acpi@vger.kernel.org, lenb@kernel.org,
	ibm-acpi-devel@lists.sourceforge.net
Subject: Re: Patch to correct battery capacity values on Thinkpads (repost)
Date: Wed, 14 Nov 2012 16:04:43 +0000	[thread overview]
Message-ID: <20121114160443.GA9108@srcf.ucam.org> (raw)
In-Reply-To: <20121114095857.29582.qmail@stuge.se>

On Wed, Nov 14, 2012 at 10:58:57AM +0100, Peter Stuge wrote:
> Matthew Garrett wrote:
> > > My guess is that this problem has been around ever since those machines
> > > have been released, but because the most common Thinkpad batteries are
> > > rated at 10.8V, the error (8%) is small enough that it simply hasn't been
> > > noticed or at least nobody could be bothered to look into it.
> > 
> > Yeah, the DSDT simply multiples the values by 10 when it's in this 
> > state. But the issue is purely cosmetic, right? I can't see any reason 
> > anything would be using the design voltage in calculations.
> 
> current energy percent = 100 * energy_now / energy_full_design

Right. That's not the voltage.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2012-11-14 16:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12  5:09 Patch to correct battery capacity values on Thinkpads (repost) Kamil Iskra
2012-11-12 20:22 ` Henrique de Moraes Holschuh
2012-11-16 21:46   ` Rafael J. Wysocki
2012-11-14  7:41 ` Matthew Garrett
2012-11-14  9:58   ` Peter Stuge
2012-11-14 16:04     ` Matthew Garrett [this message]
2012-11-14 16:54   ` Kamil Iskra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121114160443.GA9108@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=kamil@iskra.name \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.