From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Henrik Rydberg" Subject: Re: [PATCH v4 13/14] HID: hid-multitouch: fix Win 8 protocol Date: Wed, 14 Nov 2012 19:47:26 +0100 Message-ID: <20121114184726.GA11943@polaris.bitmath.org> References: <1352908766-4492-1-git-send-email-benjamin.tissoires@gmail.com> <1352908766-4492-14-git-send-email-benjamin.tissoires@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtprelay-h21.telenor.se ([195.54.99.196]:34413 "EHLO smtprelay-h21.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423178Ab2KNSk6 (ORCPT ); Wed, 14 Nov 2012 13:40:58 -0500 Content-Disposition: inline In-Reply-To: <1352908766-4492-14-git-send-email-benjamin.tissoires@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Benjamin Tissoires Cc: Dmitry Torokhov , Jiri Kosina , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Nov 14, 2012 at 04:59:25PM +0100, Benjamin Tissoires wrote: > The Win 8 protocol specify the fact that each valid touch must be reported > within a frame until it is released. > We can therefore use the always_valid quirk and dismiss reports when we see > duplicate contacts ID. > > We recognize Win8 certified devices from their vendor feature 0xff0000c5 > where Microsoft put a signed blob in the report to check if the device > passed the certification. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/hid-multitouch.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 5f26b2f..efae60c 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -295,6 +295,18 @@ static void mt_feature_mapping(struct hid_device *hdev, > td->maxcontacts = td->mtclass.maxcontacts; > > break; > + case 0xff0000c5: > + if (field->report_count == 256 && field->report_size == 8) { > + /* Win 8 devices need special quirks */ > + __s32 *quirks = &td->mtclass.quirks; > + *quirks |= MT_QUIRK_ALWAYS_VALID; > + *quirks |= MT_QUIRK_IGNORE_DUPLICATES; > + *quirks |= MT_QUIRK_HOVERING; > + *quirks &= ~MT_QUIRK_NOT_SEEN_MEANS_UP; > + *quirks &= ~MT_QUIRK_VALID_IS_INRANGE; > + *quirks &= ~MT_QUIRK_VALID_IS_CONFIDENCE; > + } > + break; > } > } > > -- > 1.8.0 > Reviewed-by: Henrik Rydberg Thanks, Henrik