From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 05/17] cgroup: cgroup->dentry isn't a RCU pointer Date: Wed, 14 Nov 2012 10:55:04 -0800 Message-ID: <20121114185504.GG21185@mtj.dyndns.org> References: <1352775704-9023-1-git-send-email-tj@kernel.org> <1352775704-9023-6-git-send-email-tj@kernel.org> <50A37B0A.7010608@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=BuMScMWLEWTdqySBE9As4VF+gVDAjZN21lfZJNQTrCA=; b=P7MhrahJ8EXf/3o7yO0o7FAkD+E7F/FAVOrSVnxfPQRNC4ZU/aOsefvnZhMTQ46ME/ wVb3kf1XJ9JYCszKo6FFwCySC5Ut9bOrsmZHCQJG5D1kQLJrwh619GRSiUt26NEjY/wh 1j9EkX+8KKilzLkyNLkYe7eLJcDq2q5UF5EYBYtEe13KelqScVB6+EY52nd8tRK4eaHC rkMOaB8A4YjHEUBjMQ4mGIBmIVO1J+PplsYZmTkaapS0D3itWoT5bOZGHb4wKFz6pE8u K0D/z7V/B1bPispuLHCFZtgyiZEt04pst9bgi+EEZpC54i17qAUGYQHibydBgKFaPe3N kcSQ== Content-Disposition: inline In-Reply-To: <50A37B0A.7010608-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Glauber Costa Cc: mhocko-AlSwsSmVLrQ@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hello, Glauber. On Wed, Nov 14, 2012 at 03:05:46PM +0400, Glauber Costa wrote: > Will memcontrol.c need similar amendments? > > The code that lives in -mm and includes kmemcg includes the following > excerpt: > > rcu_read_lock(); > dentry = rcu_dereference(memcg->css.cgroup->dentry); > rcu_read_unlock(); Ooh, yeah, hmmm... that should happen after this series gets merged. I'll mark it as pending. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756449Ab2KNSzN (ORCPT ); Wed, 14 Nov 2012 13:55:13 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:43313 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502Ab2KNSzJ (ORCPT ); Wed, 14 Nov 2012 13:55:09 -0500 Date: Wed, 14 Nov 2012 10:55:04 -0800 From: Tejun Heo To: Glauber Costa Cc: lizefan@huawei.com, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, mhocko@suse.cz Subject: Re: [PATCH 05/17] cgroup: cgroup->dentry isn't a RCU pointer Message-ID: <20121114185504.GG21185@mtj.dyndns.org> References: <1352775704-9023-1-git-send-email-tj@kernel.org> <1352775704-9023-6-git-send-email-tj@kernel.org> <50A37B0A.7010608@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50A37B0A.7010608@parallels.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Glauber. On Wed, Nov 14, 2012 at 03:05:46PM +0400, Glauber Costa wrote: > Will memcontrol.c need similar amendments? > > The code that lives in -mm and includes kmemcg includes the following > excerpt: > > rcu_read_lock(); > dentry = rcu_dereference(memcg->css.cgroup->dentry); > rcu_read_unlock(); Ooh, yeah, hmmm... that should happen after this series gets merged. I'll mark it as pending. Thanks. -- tejun