From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: Kent Yoder <key@linux.vnet.ibm.com>
Cc: Marcel Selhorst <tpmdd@selhorst.net>,
Sirrix AG <tpmdd@sirrix.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] char/tpm: simplify duration calculation and eliminate sparse warning.
Date: Wed, 14 Nov 2012 23:37:06 +0100 [thread overview]
Message-ID: <201211142337.06884.PeterHuewe@gmx.de> (raw)
In-Reply-To: <20121114221826.GC533@ennui.austin.ibm.com>
Am Mittwoch, 14. November 2012, 23:18:26 schrieb Kent Yoder:
> On Mon, Nov 12, 2012 at 11:37:18PM +0100, Peter Huewe wrote:> >
> > This patch also gets rid of the (false positive) sparse warning:
> > drivers/char/tpm/tpm.c:360 tpm_calc_ordinal_duration() error: buffer
> > overflow 'tpm_protected_ordinal_duration' 12 <= 243
>
> I'm not seeing this sparse warning, how did you get it?
Oh sorry
s/sparse/smatch/
It was a smatch warning, not sparse - sorry about that:
/data/data-old/linux-2.6/drivers/char/tpm $ make -C /data/data-old/linux-2.6/ M=`pwd` C=1 CHECK=smatch
make: Entering directory `/data/data-old/linux-2.6'
LD /data/data-old/linux-2.6/drivers/char/tpm/built-in.o
CHECK /data/data-old/linux-2.6/drivers/char/tpm/tpm.c
/data/data-old/linux-2.6/drivers/char/tpm/tpm.c:360 tpm_calc_ordinal_duration() error: buffer overflow 'tpm_protected_ordinal_duration' 12 <= 243
CC [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm.o
CHECK /data/data-old/linux-2.6/drivers/char/tpm/tpm_eventlog.c
CC [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_eventlog.o
CHECK /data/data-old/linux-2.6/drivers/char/tpm/tpm_acpi.c
CC [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_acpi.o
CHECK /data/data-old/linux-2.6/drivers/char/tpm/tpm_ppi.c
CC [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_ppi.o
LD [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_bios.o
CHECK /data/data-old/linux-2.6/drivers/char/tpm/tpm_tis.c
CC [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_tis.o
CHECK /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_infineon.c
CC [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_infineon.o
CHECK /data/data-old/linux-2.6/drivers/char/tpm/tpm_nsc.c
CC [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_nsc.o
CHECK /data/data-old/linux-2.6/drivers/char/tpm/tpm_atmel.c
CC [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_atmel.o
CHECK /data/data-old/linux-2.6/drivers/char/tpm/tpm_infineon.c
CC [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_infineon.o
Building modules, stage 2.
MODPOST 7 modules
CC /data/data-old/linux-2.6/drivers/char/tpm/tpm.mod.o
LD [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm.ko
CC /data/data-old/linux-2.6/drivers/char/tpm/tpm_atmel.mod.o
LD [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_atmel.ko
CC /data/data-old/linux-2.6/drivers/char/tpm/tpm_bios.mod.o
LD [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_bios.ko
CC /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_infineon.mod.o
LD [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_infineon.ko
CC /data/data-old/linux-2.6/drivers/char/tpm/tpm_infineon.mod.o
LD [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_infineon.ko
CC /data/data-old/linux-2.6/drivers/char/tpm/tpm_nsc.mod.o
LD [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_nsc.ko
CC /data/data-old/linux-2.6/drivers/char/tpm/tpm_tis.mod.o
LD [M] /data/data-old/linux-2.6/drivers/char/tpm/tpm_tis.ko
make: Leaving directory `/data/data-old/linux-2.6'
next prev parent reply other threads:[~2012-11-14 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 22:37 [PATCH 1/2] char/tpm: Remove duplicated lookup table Peter Huewe
2012-11-12 22:37 ` [PATCH 2/2] char/tpm: simplify duration calculation and eliminate sparse warning Peter Huewe
2012-11-14 22:18 ` Kent Yoder
2012-11-14 22:37 ` Peter Hüwe [this message]
2012-11-15 16:42 ` Kent Yoder
[not found] ` <fa7287de-06dd-40b4-9d9a-56fcc8a5f670@email.android.com>
2012-11-15 21:53 ` Kent Yoder
2012-11-15 23:31 ` [PATCH v2] char/tpm: simplify duration calculation and eliminate smatch warning Peter Huewe
2012-11-16 17:33 ` Kent Yoder
2012-11-14 22:17 ` [PATCH 1/2] char/tpm: Remove duplicated lookup table Kent Yoder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211142337.06884.PeterHuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=key@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=tpmdd@sirrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.