Re: [PATCH] i2c: mxs: Handle i2c DMA failure properly

[Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>]

Dear Tim Michals,

> On Wed, Nov 14, 2012 at 9:22 AM, Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> wrote:
> > Dear Fabio Estevam,
> > 
> > > Hi Marek,
> > > 
> > > On Wed, Nov 14, 2012 at 12:31 PM, Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> wrote:
> > > > Properly terminate the DMA transfer in case the DMA PIO transfer
> > > > or setup fails for any reason. While at it, enable support for
> > > > SMBUS_QUICK. This essentially fixes i2c-detect on this IP.
> > > 
> > > Shouldn't this be split into two patches?
> > 
> > It should, but then it fixes one problem, so I stuck it into one ...
> > 
> > > Regards,
> > > 
> > > Fabio Estevam
> > 
> > Best regards,
> > Marek Vasut
>
> Dear Marek Vasut,
> 
> This patch
>  @@ -150,8 +150,6 @@ static void mxs_i2c_reset(struct mxs_i2c
>   writel(i2c->speed->timing2, i2c->regs + MXS_I2C_TIMING2);
> 
>   writel(MXS_I2C_IRQ_MASK << 8, i2c->regs + MXS_I2C_CTRL1_SET);
> -
> - dmaengine_terminate_all(i2c->dmach);
>  }

This patch doesn't apply, can you elaborate ?

Moreover ... read either RFC1855 properly [1] and/or read the mailing list 
etiquette please (!). Especially the part about top-posting. Do us a favor.

> This patch fixes current DMA requests which time out or error returned by
> the ISR.
> 
> Tim

[1] http://www.ietf.org/rfc/rfc1855.txt

Best regards,
Marek Vasut