From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eric Millbrandt <emillbrandt@dekaresearch.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: codecs/wm8978: Only reconfigure GPIO1 when used for PLL output
Date: Thu, 15 Nov 2012 14:20:38 +0900 [thread overview]
Message-ID: <20121115052036.GE7599@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <0A40042D85E7C84DB443060EC44B3FD3459CEDE0D5@dekaexchange07.deka.local>
[-- Attachment #1.1: Type: text/plain, Size: 579 bytes --]
On Tue, Nov 13, 2012 at 09:43:08AM -0500, Eric Millbrandt wrote:
> However, I agree that the handling of the pin is odd. Does OPCLK really need
> to be reconfigured as input whenever the PLL values are updated? I didn't
> see anything in the user manual to suggest that that needed to be done.
It should not be a requirement of the device itself. It might be a
requirement of something using the clock but the system doing that
should take care of remuxing the pin as needed. What I'd suggest doing
here is removing the management of the pin completely from this
function.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-11-15 5:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 17:33 [PATCH] ASoC: codecs/wm8978: Only reconfigure GPIO1 when used for PLL output Eric Millbrandt
2012-11-13 6:44 ` Mark Brown
2012-11-13 14:43 ` Eric Millbrandt
2012-11-15 5:20 ` Mark Brown [this message]
2012-11-15 19:35 ` Eric Millbrandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115052036.GE7599@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=emillbrandt@dekaresearch.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.