From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>, hpa@linux.intel.com
Subject: Re: Wrong defaults in 3.7-rc3
Date: Thu, 15 Nov 2012 09:43:24 -0200 [thread overview]
Message-ID: <20121115094324.2760bc8d@redhat.com> (raw)
In-Reply-To: <20121115110620.GA3451@elf.ucw.cz>
Em Thu, 15 Nov 2012 12:06:20 +0100
Pavel Machek <pavel@ucw.cz> escreveu:
> DiBcom DiB0070 silicon base-band tuner (DVB_TUNER_DIB0070) [M/n/y/?]
> (NEW) n
> DiBcom DiB0090 silicon base-band tuner (DVB_TUNER_DIB0090) [M/n/y/?]
> (NEW) n
>
> M is never good config default.
Had you ever seen the Kconfig logic for tuners? They're not enabled by default.
config MEDIA_SUBDRV_AUTOSELECT
bool "Autoselect tuners and i2c modules to build"
depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_CAMERA_SUPPORT
default y
help
By default, a media driver auto-selects all possible i2c
devices that are used by any of the supported devices.
This is generally the right thing to do, except when there
are strict constraints with regards to the kernel size,
like on embedded systems.
Use this option with care, as deselecting ancillary drivers which
are, in fact, necessary will result in the lack of the needed
functionality for your device (it may not tune or may not have
the need demodulers).
If unsure say Y.
...
menu "Customise DVB Frontends"
visible if !MEDIA_SUBDRV_AUTOSELECT
comment "Multistandard (satellite) frontends"
depends on DVB_CORE
...
config DVB_TUNER_DIB0070
tristate "DiBcom DiB0070 silicon base-band tuner"
depends on I2C
default m if !MEDIA_SUBDRV_AUTOSELECT
help
A driver for the silicon baseband tuner DiB0070 from DiBcom.
This device is only used inside a SiP called together with a
demodulator for now.
People should never disable MEDIA_SUBDRV_AUTOSELECT, except if they know
exactly what they're doing and they have very strict diskspace constraints,
as the DVB driver may stop working without support for the needed
ancillary chips present at the DVB card.
The default "M" is there to prevent people to open NOT_A_BUG bugzillas
when they do stupid things like disabling MEDIA_SUBDRV_AUTOSELECT without
knowing that this can break the driver for their cards.
--
Regards,
Mauro
next prev parent reply other threads:[~2012-11-15 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 11:06 Wrong defaults in 3.7-rc3 Pavel Machek
2012-11-15 11:43 ` Mauro Carvalho Chehab [this message]
2012-11-16 21:32 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115094324.2760bc8d@redhat.com \
--to=mchehab@redhat.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.