From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Srinidhi Kasagar
<srinidhi.kasagar-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Cc: "chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout
Date: Thu, 15 Nov 2012 11:18:20 +0100 [thread overview]
Message-ID: <20121115101820.GC418@pengutronix.de> (raw)
In-Reply-To: <20121115095741.GA6280@bnru10>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote:
> On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote:
> >
> > > > - if (timeout < 0) {
> > > > - dev_err(&dev->adev->dev,
> > > > - "wait_for_completion_timeout "
> > > > - "returned %d waiting for event\n", timeout);
> > > > - status = timeout;
> > > > - }
> > > > -
> > > No, it is wrong. You need to update the status variable in the case of timeout.
> >
> > Looking at the patch context, such code comes later.
> But it causes regressions; without looking at the "later" code, we can't afford merging
> this code now.
Later as in "a few lines later" not "some time later". Or am I missing
something else?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout
Date: Thu, 15 Nov 2012 11:18:20 +0100 [thread overview]
Message-ID: <20121115101820.GC418@pengutronix.de> (raw)
In-Reply-To: <20121115095741.GA6280@bnru10>
On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote:
> On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote:
> >
> > > > - if (timeout < 0) {
> > > > - dev_err(&dev->adev->dev,
> > > > - "wait_for_completion_timeout "
> > > > - "returned %d waiting for event\n", timeout);
> > > > - status = timeout;
> > > > - }
> > > > -
> > > No, it is wrong. You need to update the status variable in the case of timeout.
> >
> > Looking at the patch context, such code comes later.
> But it causes regressions; without looking at the "later" code, we can't afford merging
> this code now.
Later as in "a few lines later" not "some time later". Or am I missing
something else?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121115/24943c8e/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <w.sang@pengutronix.de>
To: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>
Cc: "chuansheng.liu@intel.com" <chuansheng.liu@intel.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout
Date: Thu, 15 Nov 2012 11:18:20 +0100 [thread overview]
Message-ID: <20121115101820.GC418@pengutronix.de> (raw)
In-Reply-To: <20121115095741.GA6280@bnru10>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote:
> On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote:
> >
> > > > - if (timeout < 0) {
> > > > - dev_err(&dev->adev->dev,
> > > > - "wait_for_completion_timeout "
> > > > - "returned %d waiting for event\n", timeout);
> > > > - status = timeout;
> > > > - }
> > > > -
> > > No, it is wrong. You need to update the status variable in the case of timeout.
> >
> > Looking at the patch context, such code comes later.
> But it causes regressions; without looking at the "later" code, we can't afford merging
> this code now.
Later as in "a few lines later" not "some time later". Or am I missing
something else?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-11-15 10:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 17:18 [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout Chuansheng Liu
2012-11-06 17:18 ` Chuansheng Liu
2012-11-06 17:21 ` [PATCH 2/7] OMAPDSS: DISPC: " Chuansheng Liu
2012-11-06 11:30 ` Tomi Valkeinen
2012-11-06 17:22 ` [PATCH 3/7] OMAPDSS: APPLY: " Chuansheng Liu
2012-11-06 11:31 ` Tomi Valkeinen
2012-11-06 17:28 ` [PATCH 4/7] wlcore: " Chuansheng Liu
2012-11-06 17:31 ` [PATCH 5/7] can: janz-ican3: " Chuansheng Liu
2012-11-06 11:43 ` Marc Kleine-Budde
2012-11-06 17:33 ` [PATCH 6/7] mx3fb: " Chuansheng Liu
2012-11-06 17:36 ` [PATCH 7/7] IB/srpt: " Chuansheng Liu
2012-11-16 18:23 ` [PATCH 4/7] wlcore: " Luciano Coelho
2012-11-12 17:26 ` [PATCH 1/7] I2c-nomadik: " Wolfram Sang
2012-11-12 17:26 ` Wolfram Sang
2012-11-13 1:21 ` Liu, Chuansheng
2012-11-13 1:21 ` Liu, Chuansheng
2012-11-13 7:58 ` Wolfram Sang
2012-11-13 7:58 ` Wolfram Sang
[not found] ` <20121113075813.GA23119-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-13 8:00 ` Liu, Chuansheng
2012-11-13 8:00 ` Liu, Chuansheng
2012-11-13 8:00 ` Liu, Chuansheng
[not found] ` <CACRpkdYekQF5111NSNSPeaHdxgS_gpXkCjqT1n-n1_iAdDXbSg@mail.gmail.com>
2012-11-15 8:49 ` Fwd: " Srinidhi Kasagar
2012-11-15 8:49 ` Srinidhi Kasagar
2012-11-15 8:49 ` Srinidhi Kasagar
2012-11-15 9:29 ` Wolfram Sang
2012-11-15 9:29 ` Wolfram Sang
2012-11-15 9:29 ` Wolfram Sang
[not found] ` <20121115092953.GA418-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-15 9:57 ` Srinidhi Kasagar
2012-11-15 9:57 ` Srinidhi Kasagar
2012-11-15 9:57 ` Srinidhi Kasagar
2012-11-15 10:18 ` Wolfram Sang [this message]
2012-11-15 10:18 ` Wolfram Sang
2012-11-15 10:18 ` Wolfram Sang
[not found] ` <20121115101820.GC418-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-15 11:18 ` Srinidhi Kasagar
2012-11-15 11:18 ` Srinidhi Kasagar
2012-11-15 11:18 ` Srinidhi Kasagar
2012-11-15 10:52 ` Chuansheng Liu
2012-11-15 10:52 ` Chuansheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115101820.GC418@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=srinidhi.kasagar-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.