From: Aurelien Jarno <aurelien@aurel32.net>
To: "Johnson, Eric" <ericj@mips.com>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"chenwj@cs.nctu.edu.tw" <chenwj@cs.nctu.edu.tw>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"陳韋任 (Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>,
"Jia Liu" <proljc@gmail.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode
Date: Thu, 15 Nov 2012 15:04:24 +0100 [thread overview]
Message-ID: <20121115140424.GC21046@ohm.aurel32.net> (raw)
In-Reply-To: <AD431C1EF67D4B4B801AEC089EB7ED48014488ABEC@exchdb03.mips.com>
On Thu, Nov 15, 2012 at 02:34:31AM +0000, Johnson, Eric wrote:
> Hi Chen,
>
> Please only remove the POOL48A opcode.
>
> The others are documented in the microMIPS64 Instruction Set manual ( http://www.mips.com/secure-download/index.dot?product_name=/auth/MD00087-2B-MIPS64BIS-AFP-03.51.pdf ). See http://www.mips.com/products/architectures/mips64/ for other relavent docs.
>
> Instead of removing them please surround the POOL32S, DADDIU32, SD32, and LD32 opcodes with
> #if defined(TARGET_MIPS64)
>
I don't think a #if is necessary there, this makes the code more
difficult to read, while it doesn't change anything on the generated
code.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2012-11-15 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 2:15 [Qemu-trivial] [PATCH] target-mips: Clean up microMIPS32 major opcode 陳韋任 (Wei-Ren Chen)
2012-11-15 2:34 ` [Qemu-trivial] [Qemu-devel] " Johnson, Eric
2012-11-15 3:26 ` 陳韋任 (Wei-Ren Chen)
2012-11-15 4:01 ` Johnson, Eric
2012-11-15 5:51 ` 陳韋任 (Wei-Ren Chen)
2012-11-15 17:30 ` Johnson, Eric
2012-11-15 14:04 ` Aurelien Jarno [this message]
2012-11-15 17:23 ` Johnson, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115140424.GC21046@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=chenwj@cs.nctu.edu.tw \
--cc=chenwj@iis.sinica.edu.tw \
--cc=ericj@mips.com \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.