From: Tejun Heo <tj@kernel.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: fuse-devel@lists.sourceforge.net,
Miklos Szeredi <miklos@szeredi.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cuse: do not register multiple devices with the same name
Date: Thu, 15 Nov 2012 06:44:04 -0800 [thread overview]
Message-ID: <20121115144404.GA7306@mtj.dyndns.org> (raw)
In-Reply-To: <1352982197-7447-1-git-send-email-dh.herrmann@googlemail.com>
On Thu, Nov 15, 2012 at 01:23:17PM +0100, David Herrmann wrote:
> We do not check whether we already registered a CUSE device with a given
> name so we might end up with two devices with the same name. Sysfs will
> then complain as it cannot create suitable directories.
>
> This patch makes the init-command fail if there is already a device with
> the given name. To avoid race-conditions, we protect the whole
> registration with a mutex now.
>
> Following the sysfs warnings when registering two devices with the same
> name:
...
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Acked-by: Tejun Heo <tj@kernel.org>
But it probably would be better to separate out mutex conversion as a
separate patch.
Thanks!
--
tejun
next prev parent reply other threads:[~2012-11-15 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 12:23 [PATCH v2] cuse: do not register multiple devices with the same name David Herrmann
2012-11-15 14:44 ` Tejun Heo [this message]
2012-11-15 16:02 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115144404.GA7306@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=dh.herrmann@googlemail.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.