All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jon Mason <jon.mason@intel.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-pci@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
	Nicholas Bellinger <nab@linux-iscsi.org>
Subject: Re: [PATCH v5 1/2] PCI-Express Non-Transparent Bridge Support
Date: Thu, 15 Nov 2012 16:29:59 -0800	[thread overview]
Message-ID: <20121116002959.GB20876@kroah.com> (raw)
In-Reply-To: <1352160669-4330-2-git-send-email-jon.mason@intel.com>

On Mon, Nov 05, 2012 at 05:11:08PM -0700, Jon Mason wrote:
> +static int __init ntb_init_module(void)
> +{
> +	pr_info("%s: %s, version %s\n", KBUILD_MODNAME, NTB_NAME, NTB_VER);

No need to be noisy.

> +
> +	return pci_register_driver(&ntb_pci_driver);
> +}
> +module_init(ntb_init_module);
> +
> +static void __exit ntb_exit_module(void)
> +{
> +	pci_unregister_driver(&ntb_pci_driver);
> +
> +	pr_info("%s: Driver removed\n", KBUILD_MODNAME);

Same here, don't print out needless things.

> +}
> +module_exit(ntb_exit_module);

This all can be wrapped up using the pci_module() macro instead.

thanks,

greg k-h

  parent reply	other threads:[~2012-11-16  0:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06  0:11 [PATCH v5 0/2] PCI-Express Non-Transparent Bridge Support Jon Mason
2012-11-06  0:11 ` [PATCH v5 1/2] " Jon Mason
2012-11-16  0:29   ` Greg KH
2012-11-16  1:06     ` Jon Mason
2012-11-16  1:18       ` Greg KH
2012-11-16  0:29   ` Greg KH [this message]
2012-11-06  0:11 ` [PATCH v5 2/2] net: Add support for NTB virtual ethernet device Jon Mason
2012-11-16  0:30   ` Greg KH
2012-11-16  1:13     ` Jon Mason
2012-11-16  1:26       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121116002959.GB20876@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dave.jiang@intel.com \
    --cc=jon.mason@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.