From: Wolfram Sang <w.sang@pengutronix.de>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [RESEND PATCH v3 1/4] i2c: introduce i2c-cbus driver
Date: Fri, 16 Nov 2012 12:30:14 +0100 [thread overview]
Message-ID: <20121116113014.GA19028@pengutronix.de> (raw)
In-Reply-To: <1352747326-2195-2-git-send-email-aaro.koskinen@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
On Mon, Nov 12, 2012 at 09:08:42PM +0200, Aaro Koskinen wrote:
> Add i2c driver to enable access to devices behind CBUS on Nokia Internet
> Tablets.
>
> The patch also adds CBUS I2C configuration for N8x0 which is one of the
> users of this driver.
>
> Cc: linux-i2c@vger.kernel.org
> Acked-by: Felipe Balbi <balbi@ti.com>
> Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Cc: Wolfram Sang <w.sang@pengutronix.de>
Mostly good, but the devicetree binding description is missing.
Please add a proper file with the same name as the driver to
Documentation/devicetree/bindings/i2c.
Also, it might make sense to rename the driver to i2c-cbus-gpio?
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-11-16 11:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 19:08 [RESEND PATCH v3 0/4] cbus/retu drivers Aaro Koskinen
[not found] ` <1352747326-2195-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2012-11-12 19:08 ` [RESEND PATCH v3 1/4] i2c: introduce i2c-cbus driver Aaro Koskinen
2012-11-12 19:08 ` Aaro Koskinen
2012-11-16 11:30 ` Wolfram Sang [this message]
2012-11-12 19:08 ` [RESEND PATCH v3 2/4] mfd: introduce retu-mfd driver Aaro Koskinen
2012-11-20 18:34 ` Tony Lindgren
2012-11-20 18:38 ` Tony Lindgren
2012-11-12 19:08 ` [RESEND PATCH v3 3/4] watchdog: introduce retu_wdt driver Aaro Koskinen
2012-11-12 19:08 ` [RESEND PATCH v3 4/4] input: misc: introduce retu-pwrbutton Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116113014.GA19028@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=aaro.koskinen@iki.fi \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.