All of lore.kernel.org
 help / color / mirror / Atom feed
From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: imx: ehci-imx35: fix host power mask bit
Date: Fri, 16 Nov 2012 14:25:31 +0100	[thread overview]
Message-ID: <20121116142531.228251f6@eb-e6520> (raw)
In-Reply-To: <1353063197.3647.27.camel@mars>

Hi Christoph,

Le Fri, 16 Nov 2012 11:53:17 +0100,
Christoph Fritz <chf.fritz@googlemail.com> a ?crit :

> This patch sets HPM (Host power mask bit) to bit 16 according to i.MX35
> Reference Manual. Falsely it was set to bit 8, but this controls pull-up
> Impedance.
> 
> Reported-by: Michael Burkey <mdburkey@gmail.com>
> Cc: Stable <stable@vger.kernel.org>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
Acked-by: Eric B?nard <eric@eukrea.com>
the same problem exists in arch/arm/mach-imx/ehci-imx25.c may you
please also fix it in your patch at the same time ?

Thanks
Eric

> ---
>  arch/arm/mach-imx/ehci-imx35.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/ehci-imx35.c b/arch/arm/mach-imx/ehci-imx35.c
> index a596f70..554e7cc 100644
> --- a/arch/arm/mach-imx/ehci-imx35.c
> +++ b/arch/arm/mach-imx/ehci-imx35.c
> @@ -30,7 +30,7 @@
>  #define MX35_H1_SIC_SHIFT	21
>  #define MX35_H1_SIC_MASK	(0x3 << MX35_H1_SIC_SHIFT)
>  #define MX35_H1_PP_BIT		(1 << 18)
> -#define MX35_H1_PM_BIT		(1 << 8)
> +#define MX35_H1_PM_BIT		(1 << 16)
>  #define MX35_H1_IPPUE_UP_BIT	(1 << 7)
>  #define MX35_H1_IPPUE_DOWN_BIT	(1 << 6)
>  #define MX35_H1_TLL_BIT		(1 << 5)

  reply	other threads:[~2012-11-16 13:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16 10:53 ARM: imx: ehci-imx35: fix host power mask bit Christoph Fritz
2012-11-16 13:25 ` Eric Bénard [this message]
2012-11-16 14:39   ` [PATCH] ARM: imx: ehci: " Christoph Fritz
2012-11-16 14:55     ` Sascha Hauer
2012-11-16 18:18       ` Michael D. Burkey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121116142531.228251f6@eb-e6520 \
    --to=eric@eukrea.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.