From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
spear-devel <spear-devel@list.st.com>,
linux-kernel@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH 4/6] dma: ep93xx_dma: reuse is_slave_xfer helper
Date: Fri, 16 Nov 2012 17:33:09 +0200 [thread overview]
Message-ID: <20121116153309.GX17774@intel.com> (raw)
In-Reply-To: <1353074360-1903-5-git-send-email-andriy.shevchenko@linux.intel.com>
On Fri, Nov 16, 2012 at 03:59:17PM +0200, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/dma/ep93xx_dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index bcfde40..7c26354 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -903,8 +903,7 @@ static int ep93xx_dma_alloc_chan_resources(struct dma_chan *chan)
> switch (data->port) {
> case EP93XX_DMA_SSP:
> case EP93XX_DMA_IDE:
> - if (data->direction != DMA_MEM_TO_DEV &&
> - data->direction != DMA_DEV_TO_MEM)
> + if (!is_slave_xfter(data->direction))
> return -EINVAL;
> break;
> default:
> --
> 1.7.10.4
next prev parent reply other threads:[~2012-11-16 15:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 13:59 [PATCH 0/6] dmaengine: introduce is_slave_xfer helper Andy Shevchenko
2012-11-16 13:59 ` [PATCH 1/6] dmaengine: introduce is_slave_xfer function Andy Shevchenko
2012-11-16 14:03 ` Viresh Kumar
2012-11-16 15:27 ` Andy Shevchenko
2012-11-16 14:21 ` Mika Westerberg
2012-11-16 15:26 ` Andy Shevchenko
2012-11-16 15:32 ` Mika Westerberg
2012-11-16 13:59 ` [PATCH 2/6] dma: at_hdmac: check direction properly for cyclic transfers Andy Shevchenko
2012-11-16 14:05 ` Viresh Kumar
2012-11-16 15:33 ` Nicolas Ferre
2012-11-16 13:59 ` [PATCH 3/6] dma: dw_dmac: check direction properly in dw_dma_cyclic_prep Andy Shevchenko
2012-11-16 13:56 ` Felipe Balbi
2012-11-16 15:30 ` Andy Shevchenko
2012-11-16 18:09 ` Felipe Balbi
2012-11-16 14:06 ` Viresh Kumar
2012-11-16 13:59 ` [PATCH 4/6] dma: ep93xx_dma: reuse is_slave_xfer helper Andy Shevchenko
2012-11-16 14:06 ` Viresh Kumar
2012-11-16 15:33 ` Mika Westerberg [this message]
2012-11-16 13:59 ` [PATCH 5/6] dma: ipu_idmac: " Andy Shevchenko
2012-11-16 13:56 ` Felipe Balbi
2012-11-16 15:32 ` Andy Shevchenko
2012-11-16 14:07 ` Viresh Kumar
2012-11-16 13:59 ` [PATCH 6/6] dma: ste_dma40: " Andy Shevchenko
2012-11-16 14:07 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116153309.GX17774@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.