From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Samuel Iglesias Gonsálvez" <siglesias@igalia.com>
Cc: Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org, jens.taprogge@taprogge.org,
linux-kernel@vger.kernel.org,
industrypack-devel@lists.sourceforge.net
Subject: Re: [PATCH] ipack: move header files to include/linux
Date: Fri, 16 Nov 2012 11:04:06 -0800 [thread overview]
Message-ID: <20121116190406.GA18986@kroah.com> (raw)
In-Reply-To: <1353089655.4563.56.camel@fourier.local.igalia.com>
On Fri, Nov 16, 2012 at 07:14:15PM +0100, Samuel Iglesias Gonsálvez wrote:
> On Fri, 2012-11-16 at 10:08 -0800, Joe Perches wrote:
> > On Fri, 2012-11-16 at 18:34 +0100, Samuel Iglesias Gonsalvez wrote:
> > > Move ipack header files to include/linux/ directory where they belong to.
> >
> > Why do these belong in include/linux?
>
> They are used for other drivers that could be in other directories.
>
> > What's wrong with path relative includes?
>
> There is nothing wrong with relative includes. It's just to do the
> things as other subsystems do: keeping the bus' header file in
> include/linux directory.
>
> Is this approach wrong for this case?
No, not at all, this is fine.
thanks,
greg k-h
prev parent reply other threads:[~2012-11-16 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 17:34 [PATCH] ipack: move header files to include/linux Samuel Iglesias Gonsalvez
2012-11-16 17:44 ` Greg Kroah-Hartman
2012-11-16 17:48 ` Samuel Iglesias Gonsálvez
2012-11-16 17:53 ` Samuel Iglesias Gonsálvez
2012-11-16 18:00 ` Greg Kroah-Hartman
2012-11-16 18:08 ` Joe Perches
2012-11-16 18:14 ` Samuel Iglesias Gonsálvez
2012-11-16 19:01 ` Joe Perches
2012-11-16 19:04 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116190406.GA18986@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jens.taprogge@taprogge.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.