Re: [patch] mm: introduce a common interface for balloon pages mobility fix

[Rafael Aquini <aquini@redhat.com>]

On Fri, Nov 16, 2012 at 11:50:12AM -0800, David Rientjes wrote:
> On Fri, 16 Nov 2012, kbuild test robot wrote:
> 
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-3.6
> > head:   12dfb061e5fd15be23451418da01281625c0eeae
> > commit: 86929cfa5f751de3d8be5a846535282730865d8a [365/437] mm: introduce a common interface for balloon pages mobility
> > config: make ARCH=sh allyesconfig
> > 
> > All warnings:
> > 
> > warning: (BALLOON_COMPACTION && TRANSPARENT_HUGEPAGE) selects COMPACTION which has unmet direct dependencies (MMU)
> > warning: (BALLOON_COMPACTION && TRANSPARENT_HUGEPAGE) selects COMPACTION which has unmet direct dependencies (MMU)
> > --
> > warning: (BALLOON_COMPACTION && TRANSPARENT_HUGEPAGE) selects COMPACTION which has unmet direct dependencies (MMU)
> > 
> 
> mm: introduce a common interface for balloon pages mobility fix
> 
> CONFIG_BALLOON_COMPACTION shouldn't be selecting options that may not be 
> supported, so make it depend on memory compaction rather than selecting 
> it.  CONFIG_COMPACTION is enabled by default for all configs that support 
> it.
>     

This is already addressed at v12 revision which is on mmtom queue already.


> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  mm/Kconfig |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -191,8 +191,7 @@ config SPLIT_PTLOCK_CPUS
>  # support for memory balloon compaction
>  config BALLOON_COMPACTION
>  	bool "Allow for balloon memory compaction/migration"
> -	select COMPACTION
> -	depends on VIRTIO_BALLOON
> +	depends on VIRTIO_BALLOON && COMPACTION
>  	help
>  	  Memory fragmentation introduced by ballooning might reduce
>  	  significantly the number of 2MB contiguous memory blocks that can be

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>