From: Thierry Reding <thierry.reding@avionic-design.de>
To: Alban Bedel <alban.bedel@avionic-design.de>
Cc: linux-kernel@vger.kernel.org, Roland Stigge <stigge@antcom.de>,
Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Subject: Re: [PATCH 2/3] pwm: lpc32xx - Properly disable the clock on device remove
Date: Fri, 16 Nov 2012 21:16:55 +0100 [thread overview]
Message-ID: <20121116201655.GA24790@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1352894295-14339-3-git-send-email-alban.bedel@avionic-design.de>
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
On Wed, Nov 14, 2012 at 12:58:14PM +0100, Alban Bedel wrote:
[...]
> static int __devexit lpc32xx_pwm_remove(struct platform_device *pdev)
> {
> struct lpc32xx_pwm_chip *lpc32xx = platform_get_drvdata(pdev);
> + int i;
This should rather be unsigned int since pwm_chip.npwm is unsigned as
well.
> +
> + for (i = 0 ; i < lpc32xx->chip.npwm ; i += 1)
No space before ';' and "i++" please.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-16 20:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 11:58 [PATCH 0/3] pwm: lpc32xx - Various small fixes Alban Bedel
2012-11-14 11:58 ` [PATCH 1/3] pwm: lpc32xx - Fix the PWM polarity Alban Bedel
2012-11-23 9:34 ` Alexandre Pereira da Silva
2012-11-23 9:53 ` Roland Stigge
2012-11-14 11:58 ` [PATCH 2/3] pwm: lpc32xx - Properly disable the clock on device remove Alban Bedel
2012-11-16 20:16 ` Thierry Reding [this message]
[not found] ` <CAAAP30GTuCB6FCvM9v-ju8y5b+UhQdDnEnHALtewfOzWnD1v=A@mail.gmail.com>
2012-11-23 9:55 ` Roland Stigge
2012-11-14 11:58 ` [PATCH 3/3] pwm: lpc32xx - Set the chip base for dynamic allocation Alban Bedel
2012-11-23 9:35 ` Alexandre Pereira da Silva
2012-11-23 9:51 ` Roland Stigge
2012-11-22 21:43 ` [PATCH 0/3] pwm: lpc32xx - Various small fixes Thierry Reding
2012-12-06 7:58 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116201655.GA24790@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=alban.bedel@avionic-design.de \
--cc=aletes.xgr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.