Re: [PATCH 1/2] ARM: tegra: paz00: Add host1x support

[Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2533 bytes --]

On Fri, Nov 16, 2012 at 11:20:55PM +0100, Marc Dietrich wrote:
> This adds host1x support which includes HDMI and LVDS support.
> 
> Signed-off-by: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
> ---
>  arch/arm/boot/dts/tegra20-paz00.dts |   27 ++++++++++++++++++++++-----
>  1 file changed, 22 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts b/arch/arm/boot/dts/tegra20-paz00.dts
> index e884fa5..3f7f5a2 100644
> --- a/arch/arm/boot/dts/tegra20-paz00.dts
> +++ b/arch/arm/boot/dts/tegra20-paz00.dts
> @@ -244,7 +244,7 @@
>  		clock-frequency = <216000000>;
>  	};
>  
> -	i2c@7000c000 {
> +	lvds_ddc: i2c@7000c000 {
>  		status = "okay";
>  		clock-frequency = <400000>;

You might want to change this to 100 kHz as well. I think some displays
don't like fast mode. Then again, if you've verified that this works on
AC100 I suppose it can just as well stay as is.

On a side-note, I've found that Tegra doesn't do proper 400 kHz either,
but rather something like 375 kHz. Stephen, is this a known issue or is
it actually supposed to be able to do exactly 400 kHz?

>  
> @@ -256,9 +256,9 @@
>  		};
>  	};
>  
> -	i2c@7000c400 {
> +	hdmi_ddc: i2c@7000c400 {
>  		status = "okay";
> -		clock-frequency = <400000>;
> +		clock-frequency = <100000>;
>  	};
>  
>  	nvec {
> @@ -399,13 +399,13 @@
>  					regulator-max-microvolt = <1800000>;
>  				};
>  
> -				ldo7 {
> +				hdmi_vdd_reg: ldo7 {
>  					regulator-name = "+3.3vs_ldo7,avdd_hdmi";
>  					regulator-min-microvolt = <3300000>;
>  					regulator-max-microvolt = <3300000>;
>  				};
>  
> -				ldo8 {
> +				hdmi_pll_reg: ldo8 {
>  					regulator-name = "+1.8vs_ldo8,avdd_hdmi_pll";
>  					regulator-min-microvolt = <1800000>;
>  					regulator-max-microvolt = <1800000>;
> @@ -499,6 +499,23 @@
>  		};
>  	};
>  
> +	host1x {

The host1x node should be sorted earlier, according to its bus address.

> +		dc@54200000 {
> +			rgb {
> +				status = "okay";
> +				nvidia,ddc-i2c-bus = <&lvds_ddc>;
> +			};
> +		};
> +
> +		hdmi {
> +			status = "okay";
> +			vdd-supply = <&hdmi_vdd_reg>;
> +			pll-supply = <&hdmi_pll_reg>;
> +			nvidia,ddc-i2c-bus = <&hdmi_ddc>;
> +			nvidia,hpd-gpio = <&gpio 111 0>; /* PN7 */
> +		};
> +	};

As Stephen already mentioned, and I think you already experienced,
tegra-drm has issues with two enabled outputs that run at different
resolutions, so you should probably keep HDMI disabled for now.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]