From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] Use PACKAGE_VERSION for POWERTOP_VERSION
Date: Sat, 17 Nov 2012 19:03:00 +0300 [thread overview]
Message-ID: <20121117160300.GA2943@swordfish> (raw)
In-Reply-To: 1353166967-24095-1-git-send-email-namhyung@gmail.com
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
On (11/18/12 00:42), Namhyung Kim wrote:
> It was missed to update POWERTOP_VERSION macro so that the
> new v2.2 release still shows v2.1 string on the header of
> ncurses window. Convert to use PACKAGE_VERSION macro which
> set by autotools to the AC_INIT version so that it cannot
> be missed anymore.
>
> Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
> ---
looks good to me, thanks.
-ss
> src/lib.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib.h b/src/lib.h
> index 8cf4632..209421a 100644
> --- a/src/lib.h
> +++ b/src/lib.h
> @@ -35,8 +35,8 @@
>
> #define _(STRING) gettext(STRING)
>
> -#define POWERTOP_VERSION "v2.1"
> -#define POWERTOP_SHORT_VERSION "2.1"
> +#define POWERTOP_VERSION "v"PACKAGE_VERSION
> +#define POWERTOP_SHORT_VERSION PACKAGE_VERSION
>
>
> extern int get_max_cpu(void);
> --
> 1.7.9.2
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>
next reply other threads:[~2012-11-17 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 16:03 Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-29 15:58 [Powertop] [PATCH] Use PACKAGE_VERSION for POWERTOP_VERSION Chris Ferron
2012-11-17 15:42 Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121117160300.GA2943@swordfish \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.