All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: Kirkwood: Convert XOR instantiation to DT.
Date: Mon, 19 Nov 2012 07:41:43 +0100	[thread overview]
Message-ID: <20121119064143.GP14643@lunn.ch> (raw)
In-Reply-To: <20121119063757.GJ22106@titan.lakedaemon.net>

On Mon, Nov 19, 2012 at 01:37:57AM -0500, Jason Cooper wrote:
> On Sun, Nov 18, 2012 at 11:44:57AM +0100, Andrew Lunn wrote:
> > Use DT to describe the two XOR DMA engines on Kirkwood. Remove the
> > C code initialization.
> > 
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > 
> > These patches depend on the refactoring/DT patches from Thomas and NOT
> > the clock patches from me. With the clock patches, a slight different
> > patch is needed, specifying a clocks property in DT and no auxdata.
> > 
> >  arch/arm/boot/dts/kirkwood.dtsi   |   38 +++++++++++++++++++++++++++++++++++++
> >  arch/arm/mach-kirkwood/board-dt.c |    6 ++----
> >  2 files changed, 40 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
> > index 4e5b815..e0ba79d 100644
> > --- a/arch/arm/boot/dts/kirkwood.dtsi
> > +++ b/arch/arm/boot/dts/kirkwood.dtsi
> > @@ -77,6 +77,44 @@
> >  			status = "okay";
> >  		};
> >  
> > +		xor at 60800 {
> > +			compatible = "marvell,orion-xor";
> > +			reg = <0x60800 0x100
> > +			       0x60A00 0x100>;
> > +			status = "okay";
> > +
> > +			xor00 {
> > +			      interrupts = <5>;
> > +			      dmacap,memcpy;
> > +			      dmacap,xor;
> > +			};
> > +			xor01 {
> > +			      interrupts = <6>;
> > +			      dmacap,memcpy;
> > +			      dmacap,xor;
> > +			      dmacap,memset;
> > +			};
> > +		};
> > +
> > +		xor at 60900 {
> > +			compatible = "marvell,orion-xor";
> > +			reg = <0x60900 0x100
> > +			       0xd0B00 0x100>;
> > +			status = "okay";
> > +
> > +			xor00 {
> > +			      interrupts = <7>;
> > +			      dmacap,memcpy;
> > +			      dmacap,xor;
> > +			};
> > +			xor01 {
> > +			      interrupts = <8>;
> > +			      dmacap,memcpy;
> > +			      dmacap,xor;
> > +			      dmacap,memset;
> > +			};
> > +		};
> > +
> >  		sata at 80000 {
> >  			compatible = "marvell,orion-sata";
> >  			reg = <0x80000 0x5000>;
> > diff --git a/arch/arm/mach-kirkwood/board-dt.c b/arch/arm/mach-kirkwood/board-dt.c
> > index d94872f..e62f10de 100644
> > --- a/arch/arm/mach-kirkwood/board-dt.c
> > +++ b/arch/arm/mach-kirkwood/board-dt.c
> > @@ -34,6 +34,8 @@ struct of_dev_auxdata kirkwood_auxdata_lookup[] __initdata = {
> >  	OF_DEV_AUXDATA("marvell,orion-sata", 0xf1080000, "sata_mv.0", NULL),
> >  	OF_DEV_AUXDATA("marvell,orion-nand", 0xf4000000, "orion_nand", NULL),
> >  	OF_DEV_AUXDATA("marvell,orion-crypto", 0xf1030000, "mv_crypto", NULL),
> > +	OF_DEV_AUXDATA("marvell,orion-xor", 0xf1060800, "mv_xor.0", NULL),
> > +	OF_DEV_AUXDATA("marvell,orion-xor", 0xf1060900, "mv_xor.1", NULL),
> 
> This conflicts with the earlier clock work.  I'll be pushing mvebu/dt in
> a bit, could you please rebase these two patches against that?

Thomas has a v2 in the works which should solve that and Sebastians comments.

       Andrew

  reply	other threads:[~2012-11-19  6:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-18 10:44 [PATCH v2 1/2] DMA: mv_xor: Add a device_control function Andrew Lunn
2012-11-18 10:44 ` [PATCH v2 2/2] ARM: Kirkwood: Convert XOR instantiation to DT Andrew Lunn
2012-11-18 17:40   ` Thomas Petazzoni
2012-11-18 18:27     ` Andrew Lunn
2012-11-19  6:37   ` Jason Cooper
2012-11-19  6:41     ` Andrew Lunn [this message]
2012-11-19  6:54       ` Jason Cooper
2012-11-18 17:40 ` [PATCH v2 1/2] DMA: mv_xor: Add a device_control function Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121119064143.GP14643@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.