All of lore.kernel.org
 help / color / mirror / Atom feed
From: thierry.reding@avionic-design.de (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Fix build error in pwm-vt8500.c
Date: Mon, 19 Nov 2012 14:03:28 +0100	[thread overview]
Message-ID: <20121119130327.GB31093@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <20121119092926.GE3290@n2100.arm.linux.org.uk>

On Mon, Nov 19, 2012 at 09:29:26AM +0000, Russell King - ARM Linux wrote:
> On Mon, Nov 19, 2012 at 03:06:19PM +1300, Tony Prisk wrote:
> > A missing '{' causes a build error in pwm-vt8500.c
> > 
> > Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> > ---
> >  drivers/pwm/pwm-vt8500.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pwm/pwm-vt8500.c b/drivers/pwm/pwm-vt8500.c
> > index 970b0c6..806f72c 100644
> > --- a/drivers/pwm/pwm-vt8500.c
> > +++ b/drivers/pwm/pwm-vt8500.c
> > @@ -100,7 +100,7 @@ static int vt8500_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
> >  	struct vt8500_chip *vt8500 = to_vt8500_chip(chip);
> >  
> >  	err = clk_enable(vt8500->clk);
> > -	if (err < 0)
> > +	if (err < 0) {
> >  		dev_err(chip->dev, "failed to enable clock\n");
> >  		return err;
> >  	};
> 
> Why does this closing brace have a semicolon after it?

Tony,

can you remove the gratuitous semicolon while at it, please?

Thanks for spotting it Russell.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121119/65466348/attachment.sig>

  reply	other threads:[~2012-11-19 13:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19  2:06 [PATCH 0/2] pwm fixes for 3.8 Tony Prisk
2012-11-19  2:06 ` [PATCH 1/2] Fix build error in pwm-vt8500.c Tony Prisk
2012-11-19  6:51   ` Thierry Reding
2012-11-19  9:29   ` Russell King - ARM Linux
2012-11-19 13:03     ` Thierry Reding [this message]
2012-11-19  2:06 ` [PATCH 2/2] pwm: vt8500: Ensure pwm clock is enabled during pwm_config Tony Prisk
2012-11-19  6:53   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121119130327.GB31093@avionic-0098.adnet.avionic-design.de \
    --to=thierry.reding@avionic-design.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.