From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu,
adilger.kernel@dilger.ca, patches@linaro.org
Subject: Re: [PATCH 1/1] ext4: Remove duplicate inclusion of ext4_extents.h in super.c
Date: Tue, 20 Nov 2012 00:23:56 +0800 [thread overview]
Message-ID: <20121119162356.GB2337@gmail.com> (raw)
In-Reply-To: <CAK9yfHyLzJE+rH3L0UN1x2dVNcEdaR=F7Z_Q2NfTidV2GKuP=g@mail.gmail.com>
On Mon, Nov 19, 2012 at 08:36:06PM +0530, Sachin Kamat wrote:
> Hi Zheng,
>
> On 19 November 2012 19:09, Zheng Liu <gnehzuil.liu@gmail.com> wrote:
> > On Mon, Nov 19, 2012 at 04:47:22PM +0530, Sachin Kamat wrote:
> >> ext4_extents.h was included twice.
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> ---
> >> fs/ext4/super.c | 1 -
> >> 1 files changed, 0 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> >> index ad6cd8a..c8a6138 100644
> >> --- a/fs/ext4/super.c
> >> +++ b/fs/ext4/super.c
> >> @@ -50,7 +50,6 @@
> >> #include "xattr.h"
> >> #include "acl.h"
> >> #include "mballoc.h"
> >> -#include "ext4_extents.h"
> >
> > Hi Sachin,
> >
> > Sorry, I don't find this duplicated code in mainline kernel 3.7-rc6.
>
> The duplicated code is available on the linux-next tree (20121115).
> The second instance was added by the commit
> "ext4: let ext4 maintain extent status tree" (commit id: 51865fda).
Good catch. Sorry for my fault that introduces this duplicated code.
The patch looks good to me.
Regards,
- Zheng
next prev parent reply other threads:[~2012-11-19 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 11:17 [PATCH 1/1] ext4: Remove duplicate inclusion of ext4_extents.h in super.c Sachin Kamat
2012-11-19 13:39 ` Zheng Liu
2012-11-19 15:00 ` Theodore Ts'o
2012-11-19 16:22 ` Zheng Liu
2012-11-19 15:06 ` Sachin Kamat
2012-11-19 16:23 ` Zheng Liu [this message]
2012-11-22 5:13 ` Sachin Kamat
2012-11-27 3:37 ` Sachin Kamat
2012-11-28 18:08 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119162356.GB2337@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.